Merge branch 'sortable-branches-push-permission' into 'master'

Make branches sortable without push permission

## What does this MR do?

Make branches on the branches page sortable without push permission.

## Why was this MR needed?

Sorting branches (a readonly action) required push permission which does not make sense.

## What are the relevant issue numbers?

fixes #18678

## Screenshots

### Before

![before](/uploads/d77d0be2599481b815cb2ef1f9c33a15/before.png)

### After

![after](/uploads/edbcf9d5ec4b2650866742ead0c2c1ed/after.png)


See merge request !5462

CHANGELOG

@@ -12,6 +12,7 @@ v 8.11.0 (unreleased)
   - Make fork counter always clickable. !5463 (winniehell)
   - Remove `search_id` of labels dropdown filter to fix 'Missleading URI for labels in Merge Requests and Issues view'. !5368 (Scott Le)
   - Load project invited groups and members eagerly in `ProjectTeam#fetch_members`
+  - Make branches sortable without push permission !5462 (winniehell)
   - Add GitLab Workhorse version to admin dashboard (Katarzyna Kobierska Ula Budziszewska)
   - Add the `sprockets-es6` gem
   - Multiple trigger variables show in separate lines (Katarzyna Kobierska Ula Budziszewska)

app/views/projects/branches/index.html.haml

@@ -7,10 +7,10 @@
     .nav-text
       Protected branches can be managed in project settings
 
-    - if can? current_user, :push_code, @project
     .nav-controls
       = form_tag(filter_branches_path, method: :get) do
         = search_field_tag :search, params[:search], { placeholder: 'Filter by branch name', id: 'branch-search', class: 'form-control search-text-input input-short', spellcheck: false }
+
       .dropdown.inline
         %button.dropdown-toggle.btn{type: 'button', 'data-toggle' => 'dropdown'}
           %span.light
@@ -27,8 +27,11 @@
               = sort_title_recently_updated
             = link_to filter_branches_path(sort: 'last_updated') do
               = sort_title_oldest_updated
+
+      - if can? current_user, :push_code, @project
         = link_to new_namespace_project_branch_path(@project.namespace, @project), class: 'btn btn-create' do
           New branch
+
   - if @branches.any?
     %ul.content-list.all-branches
       - @branches.each do |branch|