Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
b99f8411
Commit
b99f8411
authored
Aug 19, 2016
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update contribution acceptance criteria with tests requirements
parent
15bbab88
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
3 deletions
+2
-3
CONTRIBUTING.md
CONTRIBUTING.md
+2
-3
No files found.
CONTRIBUTING.md
View file @
b99f8411
...
@@ -387,9 +387,8 @@ description area. Copy-paste it to retain the markdown format.
...
@@ -387,9 +387,8 @@ description area. Copy-paste it to retain the markdown format.
1.
The change is as small as possible
1.
The change is as small as possible
1.
Include proper tests and make all tests pass (unless it contains a test
1.
Include proper tests and make all tests pass (unless it contains a test
exposing a bug in existing code). Every new file with code you created
exposing a bug in existing code). Every new class should have corresponding
must have a corresponging file with tests even if functionality is
unit tests, even if the class is exercised at a higher level, such as a feature test.
already tested somewhere else.
1.
If you suspect a failing CI build is unrelated to your contribution, you may
1.
If you suspect a failing CI build is unrelated to your contribution, you may
try and restart the failing CI job or ask a developer to fix the
try and restart the failing CI job or ask a developer to fix the
aforementioned failing test
aforementioned failing test
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment