1. 02 Jun, 2016 13 commits
    • Yorick Peterse's avatar
      Reduce Namespace queries in UserReferenceFilter · 01575e99
      Yorick Peterse authored
      This changes UserReferenceFilter so it operates using the following
      steps:
      
      1. Grab all username references from the input document.
      2. Query the corresponding Namespace objects using a single query.
      3. Iterate over all nodes to build links while re-using the objects
         queried in step 2.
      
      The impact of these changes is that a comment mentioning 5 different
      usernames no longer runs 5 different queries (1 for every username),
      instead it only runs a single query.
      01575e99
    • Yorick Peterse's avatar
      Added ReferenceFilter#nodes · 8a6c3f27
      Yorick Peterse authored
      This method returns an Array of the HTML nodes as yielded by
      ReferenceFilter#each_node. The method's return value is memoized to
      allow multiple calls without having to re-query the input document.
      8a6c3f27
    • Yorick Peterse's avatar
      Returning enums in ReferenceFilter#each_node · 2fbfb854
      Yorick Peterse authored
      This changes ReferenceFilter#each_node so that when it's called without
      a block an Enumerator is returned.
      2fbfb854
    • Achilleas Pipinellis's avatar
      Merge branch 'minor_doc_updates' into 'master' · acfbeced
      Achilleas Pipinellis authored
      Minor doc updates
      
      ## What does this MR do?
      
      Adds to and clarifies some documentation. Specifically, when using `gdb` to debug you need to detach and exit when done. Next, this clarifies the type of file locking that we require.
      
      Thanks to @northrup for the details about mandatory vs. advisory file locking.
      
      Note: These were two really small changes so I combined in to one merge request. However, I left the commits separate for clarity.
      
      See merge request !4421
      acfbeced
    • Robert Speicher's avatar
      Merge branch 'cs-unnecessary-assets' into 'master' · 30524901
      Robert Speicher authored
      Load d3 only when necessary
      
      Now d3 is only loaded on the users' show page and the graphs pages, where it's necessary.
      
      Redo of !3993.
      
      This decreases page size from 4.6MB to 4.3MB for a given Activity page (before compression), or a savings of 300KB. This is essentially a proof of concept for removing larger dependencies such as the Ace Editor, Chart.js, and Raphael, which will likely provide another 1MB of savings on most pages (again, before compression).
      
      See merge request !4394
      30524901
    • Robert Speicher's avatar
      Merge branch 'cleanup-readme' into 'master' · 34861c5f
      Robert Speicher authored
      Remove Coveralls and Semaphore badges. [ci skip]
      
      Remove Coveralls and Semaphore badges from the README. They're outdated,
      unused, and not GitLab CI :)
      
      [ci skip]
      
      See merge request !4334
      34861c5f
    • Connor Shea's avatar
      Move JS graph specs to match assets tree. · 586d1a9b
      Connor Shea authored
      586d1a9b
    • Connor Shea's avatar
      Fix teaspoon · 81f46054
      Connor Shea authored
      81f46054
    • Connor Shea's avatar
      Fix indentation · 3eb683b6
      Connor Shea authored
      3eb683b6
    • Connor Shea's avatar
      Attempt to fix the user page. · 026b7abc
      Connor Shea authored
      026b7abc
    • Connor Shea's avatar
      0256e683
    • Robert Speicher's avatar
      Merge branch 'fix-dropdown-cutoff' into 'master' · 933a6e0d
      Robert Speicher authored
      Adds a `title` attribute to the branch dropdown for when the name has been cut off.
      
      Fixes #18056 
      
      See merge request !4395
      933a6e0d
    • Robert Speicher's avatar
      Merge branch 'upgrade-devise-two-factor' into 'master' · 7d33fba7
      Robert Speicher authored
      Upgrade devise, devise-two-factor, and attr_encrypted
      
      Devise 4 includes support for Rails 5, working towards #14286. devise-async doesn't support Devise 4.0 and in 4.1 the bug that was blocking using Devise's built-in ActiveJob integration was fixed. So devise-async is removed. devise-two-factor 3.0.0 is required for Devise 4 support.
      
      attr_encrypted and encryptor are optional but recommended upgrades for devise-two-factor 3.0.0. The mode and algorithm will need to be changed in order to update to attr_encrypted 4.x in the future.
      
      See merge request !4216
      7d33fba7
  2. 01 Jun, 2016 27 commits