queries: removing uneeded attribute + fix scope bug

src/queries/complexquery.js

@@ -12,7 +12,6 @@
  * @param  {String} [spec.operator="AND"] The compare method to use
  * @param  {String} spec.key The metadata key
  * @param  {String} spec.value The value of the metadata to compare
- * @param  {String} [spec.wildcard_character="%"] The wildcard character
  */
 var ComplexQuery = newClass(Query, function (spec) {
 

src/queries/query.js

@@ -9,17 +9,9 @@
  * @class Query
  * @constructor
  */
-var Query = newClass(function (spec) {
+var Query = newClass(function () {
 
-  /**
-   * The wildcard character used to extend comparison action
-   *
-   * @attribute wildcard_character
-   * @type String
-   * @default "%"
-   * @optional
-   */
-  this.wildcard_character = spec.wildcard_character || "%";
+  var that = this, emptyFunction = function () {};
 
   /**
    * Filter the item list with matching item only
@@ -34,10 +26,10 @@ var Query = newClass(function (spec) {
    * @param  {Array} [option.limit] Couple of integer, first is an index and
    *                 second is the length.
    */
-  this.exec = function (item_list, option) {
+  that.exec = function (item_list, option) {
     var i = 0;
     while (i < item_list.length) {
-      if (!this.match(item_list[i], option.wildcard_character)) {
+      if (!that.match(item_list[i], option.wildcard_character)) {
         item_list.splice(i, 1);
       } else {
         i += 1;
@@ -62,7 +54,7 @@ var Query = newClass(function (spec) {
    * @param  {Object} item The object to test
    * @return {Boolean} true if match, false otherwise
    */
-  this.match = function (item, wildcard_character) {
+  that.match = function (item, wildcard_character) {
     return true;
   };
 
@@ -73,7 +65,7 @@ var Query = newClass(function (spec) {
    * @method toString
    * @return {String} The string version of this query
    */
-  this.toString = function () {
+  that.toString = function () {
     return "";
   };
 
@@ -84,7 +76,7 @@ var Query = newClass(function (spec) {
    * @method serialized
    * @return {Object} The jsonable object
    */
-  this.serialized = function () {
+  that.serialized = function () {
     return undefined;
   };
 

src/queries/simplequery.js

@@ -11,7 +11,6 @@
  * @param  {String} [spec.operator="="] The compare method to use
  * @param  {String} spec.key The metadata key
  * @param  {String} spec.value The value of the metadata to compare
- * @param  {String} [spec.wildcard_character="%"] The wildcard character
  */
 var SimpleQuery = newClass(Query, function (spec) {
   /**
@@ -80,7 +79,7 @@ var SimpleQuery = newClass(Query, function (spec) {
                         wildcard_character) {
     return convertSearchTextToRegExp(
       comparison_value.toString(),
-      wildcard_character || this.wildcard_character
+      wildcard_character || "%"
     ).test(object_value.toString());
   };
 
@@ -97,7 +96,7 @@ var SimpleQuery = newClass(Query, function (spec) {
                          wildcard_character) {
     return !convertSearchTextToRegExp(
       comparison_value.toString(),
-      wildcard_character || this.wildcard_character
+      wildcard_character || "%"
     ).test(object_value.toString());
   };