slapos_crm: Drop fixit and avoid catalog queries

   The fixit wasnt a good idea, since we cannot guarantee that the data will be complaint (and not changed by the administrator).

    Move Constraint from event to Support Request, since indexation might not find the Support Request while create the first ticket.

master/bt5/slapos_crm/PortalTypePropertySheetTemplateItem/property_sheet_list.xml

 <property_sheet_list>
  <portal_type id="Mail Message">
-  <item>EventSlapOSConstraint</item>
+  <item>SlapOSEventConstraint</item>
  </portal_type>
  <portal_type id="Regularisation Request">
   <item>Codification</item>
  </portal_type>
  <portal_type id="Site Message">
-  <item>EventSlapOSConstraint</item>
+  <item>SlapOSEventConstraint</item>
+ </portal_type>
+ <portal_type id="Support Request">
+  <item>SlapOSSupportRequestConstraint</item>
  </portal_type>
  <portal_type id="Web Message">
-  <item>EventSlapOSConstraint</item>
+  <item>SlapOSEventConstraint</item>
  </portal_type>
 </property_sheet_list>
\ No newline at end of file

master/bt5/slapos_crm/PropertySheetTemplateItem/portal_property_sheets/EventSlapOSConstraint.xml → master/bt5/slapos_crm/PropertySheetTemplateItem/portal_property_sheets/SlapOSEventConstraint.xml

@@ -32,7 +32,7 @@
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>EventSlapOSConstraint</string> </value>
+            <value> <string>SlapOSEventConstraint</string> </value>
         </item>
         <item>
             <key> <string>portal_type</string> </key>

master/bt5/slapos_crm/PropertySheetTemplateItem/portal_property_sheets/SlapOSSupportRequestConstraint.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="Property Sheet" module="erp5.portal_type"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>_count</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>_mt_index</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>_tree</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAQ=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>description</string> </key>
+            <value>
+              <none/>
+            </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>SlapOSSupportRequestConstraint</string> </value>
+        </item>
+        <item>
+            <key> <string>portal_type</string> </key>
+            <value> <string>Property Sheet</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+  <record id="2" aka="AAAAAAAAAAI=">
+    <pickle>
+      <global name="Length" module="BTrees.Length"/>
+    </pickle>
+    <pickle> <int>0</int> </pickle>
+  </record>
+  <record id="3" aka="AAAAAAAAAAM=">
+    <pickle>
+      <global name="OOBTree" module="BTrees.OOBTree"/>
+    </pickle>
+    <pickle>
+      <none/>
+    </pickle>
+  </record>
+  <record id="4" aka="AAAAAAAAAAQ=">
+    <pickle>
+      <global name="OOBTree" module="BTrees.OOBTree"/>
+    </pickle>
+    <pickle>
+      <none/>
+    </pickle>
+  </record>
+</ZopeData>

master/bt5/slapos_crm/PropertySheetTemplateItem/portal_property_sheets/EventSlapOSConstraint/customer_causality_related_constraint_constraint.xml → master/bt5/slapos_crm/PropertySheetTemplateItem/portal_property_sheets/SlapOSSupportRequestConstraint/causality_source_destination_constraint_constraint.xml

@@ -34,7 +34,7 @@
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>customer_causality_related_constraint_constraint</string> </value>
+            <value> <string>causality_source_destination_constraint_constraint</string> </value>
         </item>
         <item>
             <key> <string>portal_type</string> </key>
@@ -42,7 +42,7 @@
         </item>
         <item>
             <key> <string>script_id</string> </key>
-            <value> <string>Event_checkCausalityRelatedConsistency</string> </value>
+            <value> <string>SupportRequest_checkCausalitySourceDestinationConsistency</string> </value>
         </item>
       </dictionary>
     </pickle>

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/Event_checkCausalityRelatedConsistency.py

-support_request = context.getCausalityRelatedValue(portal_type="Support Request")
-
-error_list = []
-
-if support_request:
-  if context.getSource() != support_request.getDestinationDecision():
-    error_list.append(
-      'Sender should be the customer')
-    if fixit:
-      context.edit(source=support_request.getDestinationDecision())
-      assert context.getSource() == support_request.getDestinationDecision()
-
-  if context.getDestination() != support_request.getSourceSection():
-    error_list.append(
-      'Destination should be the slapos organisation')
-    if fixit:
-      context.edit(destination=support_request.getSourceSection())
-      assert context.getDestination() == support_request.getSourceSection()
-
-return error_list

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/Event_checkCustomerAsSourceOrDestinationConsistency.py

@@ -7,10 +7,5 @@ if support_request:
     customer not in context.getDestinationList() :
     error_list.append(
       'Customer should be source or destination of the event')
-    if fixit:
-      destination_list = context.getDestinationList()
-      destination_list.append(customer)
-      context.edit(destination=customer)
-      assert customer in context.getDestinationList()
 
 return error_list

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_checkCausalitySourceDestinationConsistency.py

+portal = context.getPortalObject()
+event = context.getCausalityValue(portal_type=portal.getPortalEventTypeList())
+error_list = []
+
+if event:
+  if event.getSource() != context.getDestinationDecision():
+    error_list.append(
+      'Sender of the related event should be the customer')
+
+  if event.getDestination() != context.getSourceSection():
+    error_list.append(
+      'Destination  of the related event should be the slapos organisation')
+
+return error_list

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/Event_checkCausalityRelatedConsistency.xml → master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_checkCausalitySourceDestinationConsistency.xml

@@ -54,7 +54,7 @@
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>Event_checkCausalityRelatedConsistency</string> </value>
+            <value> <string>SupportRequest_checkCausalitySourceDestinationConsistency</string> </value>
         </item>
       </dictionary>
     </pickle>

master/bt5/slapos_crm/bt/template_portal_type_property_sheet_list

-Mail Message | EventSlapOSConstraint
+Mail Message | SlapOSEventConstraint
 Regularisation Request | Codification
-Site Message | EventSlapOSConstraint
-Web Message | EventSlapOSConstraint
\ No newline at end of file
+Site Message | SlapOSEventConstraint
+Support Request | SlapOSSupportRequestConstraint
+Web Message | SlapOSEventConstraint
\ No newline at end of file

master/bt5/slapos_crm/bt/template_property_sheet_id_list

 SlapOSCRMSystemPreference
-EventSlapOSConstraint
\ No newline at end of file
+SlapOSEventConstraint
+SlapOSSupportRequestConstraint
\ No newline at end of file