1. 05 Apr, 2019 4 commits
    • Roque's avatar
      e17e873f
    • Roque's avatar
    • Roque's avatar
      erp5_officejs: removing unnecessary indexedDB database-layer and old views · f4dbb8b3
      Roque authored
      - signature layer for appcachestorage sync changed to memory type
      - obsolete post view removed
      f4dbb8b3
    • Roque's avatar
      -rebasing erp5_discussion_tool onto master- · ec63bc54
      Roque authored
      erp5_discussion: initial commit for discussion tool (WIP)
      
      erp5_officejs: web site and gadgets for discussion tool
      
      erp5_officejs_connector: forms for discussion tool
      
      erp5_post: html post jio view for discussion tool
      
      erp5_officejs_ui_test: unit tests for discussion tool
      
      [HARDCODED] only discussion tool tests
      
      erp5_discussion: adding officejs dependency to install the discussion tool site
      
      testing a fix for migration test in discussion tool
      
      erp5_hal_json_style: hateoas script extended to retrieve raw form definition
      
      erp5_officejs: rendering form on JS side
      - hardcoded JSON was removed
      - form definition is get from jio storage (erp5 for now)
      - rendering is done in controller.js using form definition and context (jio document)
      
      erp5_officejs_connector: changes on HTML post view as jio for discussion tool
      
      erp5_post: changes on html post view for discussion tool
      
      erp5_officejs: store json form definition in indexedDB
      
      erp5_officejs: adding a layer in jio data storage to replicate appcache content
      
      erp5_officejs: bug fix - missing resource in appcache file
      
      WIP: erp5_officejs: replicate appcache content into local storage
      
      erp5_officejs: new file manifest to list form json urls and other configurations
      - this prevents the appcache-local storage sync to store unnecessary resources like gadgets
      
      erp5_officejs: replicate appcache content into local storage
      - configurations like form definitions are saved as objects into data-storage.metadata to allow jio.get
      
      erp5_officejs: minor fixes and cleanup
      
      erp5_officejs: include non-json resources from appcache as blobs
      
      WIP erp5_officejs: getting rid of editable view for form rendering
      
      erp5_officejs: got rid of editable view form and using gadget_erp5_form directly
      
      erp5_officejs: removing unnecessary redirect
      
      erp5_officejs_ui_test: updating test
      
      erp5_officejs: fix in appcachestorage sync
      
      [HARCODED]  erp5_hal_json_style: remove permission controls to appcache hatoas return-dict
      
      erp5_officejs: removing comments in appcache manifest
      
      erp5_officejs: revert get rid of editable view
      - editable view is generic enough for form editing, so it will be kept
      - but submit handling is done in controller gadget
      
      erp5_officejs: cleanup in controller html
      
      erp5_officejs: bug fixing on storage migration
      - new appcachestorage hash layer is created when new storage is selected
      
      erp5_hal_json_style: missing jio_view action in ERP5 Form portal type
      - needed to get the form definition from hateoas script
      
      erp5_officejs: new parameter appcache in hateoas script
      - this new parameter disable permission check when hateoas is called by bootloader
      - appcache storage sync is canceled if storage requires authentication
      - WIP: redirect to login not working
      
      erp5_officejs: extra controls in appcachestorage sync error handling
      
      erp5_officejs: logging more error details for failing unit test
      
      erp5_officejs: more error logging for tests
      - attempt to fix test
      
      erp5_officejs: more details in log for test
      
      erp5_officejs: adding configuration manifest explicitly
      - even is it committed, test fails due to "can't get manifest"
      
      erp5_officejs: using old appcache manifest instead of the configuration one
      
      erp5_officejs: no need of explicitly commit the configuration manifest or use old manifest
      - the test failed the same with both attempts
      
      erp5_officejs_ui_test: add a check for manifest configuration file
      
      erp5_officejs_ui_test: fix in configuration manifest url
      
      erp5_officejs: attempt to fix unit test appcache sync
      
      erp5_officejs_ui_test: cleanup
      
      erp5_officejs: clean up after test fix
      
      erp5_hal_json_style: fix permission issue for appcache storage sync
      - new parameter added for this scenario
      
      [HARDCODED] erp5_hal_json_style: forcing value of html post action jio_view
      
      erp5_hal_json_style: error handling in hardcoded action value
      
      [WIP] erp5_officejs: get rid of hardcoded form name in controller gadget
      - form name comes from the document portal type action
      - for now, path to action is hardcoded. It will come from a allDocs query (not implemented yet in appcachestorage sync)
      
      erp5_hal_json_style: fix test due to hardcode
      
      erp5_officejs: jio_allDocs queries can be done on local data storage after appcachestorage sync
      
      erp5_officejs: missing hateoas urls in appcache and configuration manifests
      
      Removing unnecessary modified files from merge request
      
      erp5_officejs: minor refactoring
      
      erp5_officejs: code cleanup
      ec63bc54
  2. 04 Apr, 2019 8 commits
  3. 03 Apr, 2019 1 commit
  4. 29 Mar, 2019 1 commit
  5. 28 Mar, 2019 2 commits
  6. 26 Mar, 2019 3 commits
  7. 25 Mar, 2019 2 commits
  8. 22 Mar, 2019 1 commit
  9. 20 Mar, 2019 4 commits
    • Julien Muchembled's avatar
      qa: fix test_getServerAddress (testCMFActivity) · c335c68f
      Julien Muchembled authored
      With recent changes in CMFActivity, getServerAddress is now used
      when setting up the site, before the ZServer is started, which means:
      - getServerAddress memoized a wrong return value;
      - the test didn't fail with --load.
      c335c68f
    • Aurélien Vermylen's avatar
      Clarify "Subscribe/Unsubscribe from Timer Service". · b89e433f
      Aurélien Vermylen authored
      The button "Subscribe/Unsubscribe from Timer Service" does not clearly 
      explain the fact that it determines whether or not Alarms are enabled in
      ERP5. It is very counter-intuitive to see Alarms on "enabled" in the 
      "Configure Alarms" screen and yet not have them being run because the
      Alarm Node is not subscribed to the Timer Service.
      
      /reviewed-on nexedi/erp5!539
      b89e433f
    • Jérome Perrin's avatar
      Fix AccessToken login with ERP5 Login · 601e46e9
      Jérome Perrin authored
      Since the introduction of ERP5 Login, authentication by Access Token is broken, and it is only working if `erp5_login.getReference() == person.getUserId()`
      
      The scriptable part of access token changed, now scripts must return a user object - on which the plugin will call `getUserId` (it was not clear what they should return before, maybe login, but they should return a user id, not a login, as the token plays the same role as a login). To make it clear and to intentionally break compatibility as this is now something different, these scripts have been renamed to be `getUserValue` type based methods.
      
      /reviewed-on nexedi/erp5!838
      601e46e9
    • Jérome Perrin's avatar
      test: fix python3 syntax errors on testAccounting · d8999426
      Jérome Perrin authored
      (because my editor runs python3 pytlint)
      d8999426
  10. 19 Mar, 2019 9 commits
  11. 14 Mar, 2019 5 commits
    • Xiaowu Zhang's avatar
      erp5_trade: drop caching method for resource list · f1bbc5aa
      Xiaowu Zhang authored
      benefit is very small and unusable for user
      
      nexedi/erp5@1f254aa7
      f1bbc5aa
    • Vincent Pelletier's avatar
      Base._getAcquireLocalRoles: Optimise. · 213974eb
      Vincent Pelletier authored
      This is called when checking access permission on objects, which happens
      very often. CachingMethod has a hit cost which is too high for this use.
      Instead, generate this method as part of the portal type class, removing
      all call-time logic.
      213974eb
    • Vincent Pelletier's avatar
      all: Remove references to im_self. · 6b289998
      Vincent Pelletier authored
      It is superseded by __self__, which (where applicable) prevents
      acquisition and getattr-based traversal, improving performance.
      Patch AccessControl.users.BasicUser._check_context to extend this change
      to zope code (and simplify it in the process).
      Also, make __ac_local_roles__ accesses consistent with other places in
      our own code as well as in PAS & AccessControl.
      6b289998
    • Vincent Pelletier's avatar
      {,Propertied}User: Reduce the overhead from Developer role processing. · 240a8d26
      Vincent Pelletier authored
      getRoles is called a lot (on every restricted access, so hundreds of times
      per transaction), it is definitely not the right place to do extra
      computation, especially when their result does not change from one call
      to the next (configuration should only change on process restart, so not
      during a transaction - and even if it someday did, it should be fine to
      wait for next transaction for it to take effect).
      Instead, do the extra work when creating the user (typically once per
      transaction).
      Also, modernise python syntax (simplifications & style).
      Also, reduce code duplication from ERP5Security.ERP5UserFactory.
      240a8d26
    • Vincent Pelletier's avatar
      DCWorkflowDefinition_listObjectActions: Always return a vector. · e793b164
      Vincent Pelletier authored
      Simplifies callers, as they then do not have to test for None.
      Also, use sort(key=...), which removes the need for internal 2-tuple
      wrapping & unwrapping of all result entries.
      Also, coding style (helps line-based profiling readability) & better
      naming.
      e793b164