Remove conflicting command-line flags

We mostly did a good job of picking flags that CPython doesn't use (or at least, that
its manpage doesn't advertise), but there are a couple that need to be changed.

One is for TRAP which is a feature I don't even remember anymore, so that's removed.

The other is for stats -- '-s' is now changed to '-T'.  This will be annoying to change
on the perf-tracking side.

src/asm_writing/mc_writer.cpp

@@ -121,10 +121,6 @@ private:
     int pops_required;
 
     inline void _emitByte(uint8_t b) {
-        if (TRAP) {
-            printf(" %02x", b);
-            fflush(stdout);
-        }
         assert(addr < end_addr);
         *addr++ = b;
     }

src/core/options.cpp

@@ -36,7 +36,6 @@ bool CONTINUE_AFTER_FATAL = false;
 bool SHOW_DISASM = false;
 bool PROFILE = false;
 bool DUMPJIT = false;
-bool TRAP = false;
 bool USE_STRIPPED_STDLIB = true; // always true
 bool USE_REGALLOC_BASIC = false;
 bool PAUSE_AT_ABORT = false;

src/core/options.h

@@ -35,8 +35,8 @@ extern int OSR_THRESHOLD_T2, REOPT_THRESHOLD_T2;
 extern int SPECULATION_THRESHOLD;
 extern int MAX_OBJECT_CACHE_ENTRIES;
 
-extern bool SHOW_DISASM, FORCE_INTERPRETER, FORCE_OPTIMIZE, PROFILE, DUMPJIT, TRAP, USE_STRIPPED_STDLIB,
-    CONTINUE_AFTER_FATAL, ENABLE_INTERPRETER, ENABLE_BASELINEJIT, USE_REGALLOC_BASIC, PAUSE_AT_ABORT, ENABLE_TRACEBACKS,
+extern bool SHOW_DISASM, FORCE_INTERPRETER, FORCE_OPTIMIZE, PROFILE, DUMPJIT, USE_STRIPPED_STDLIB, CONTINUE_AFTER_FATAL,
+    ENABLE_INTERPRETER, ENABLE_BASELINEJIT, USE_REGALLOC_BASIC, PAUSE_AT_ABORT, ENABLE_TRACEBACKS,
     FORCE_LLVM_CAPI_CALLS, FORCE_LLVM_CAPI_THROWS;
 
 extern bool LOG_IC_ASSEMBLY, LOG_BJIT_ASSEMBLY;

src/jit.cpp

@@ -184,8 +184,6 @@ static void enableGdbSegfaultWatcher() {
 int handleArg(char code) {
     if (code == 'O')
         FORCE_OPTIMIZE = true;
-    else if (code == 't')
-        TRAP = true;
     else if (code == 'q')
         GLOBAL_VERBOSITY = 0;
     else if (code == 'v') {
@@ -207,7 +205,7 @@ int handleArg(char code) {
         PROFILE = true;
     } else if (code == 'j') {
         DUMPJIT = true;
-    } else if (code == 's') {
+    } else if (code == 'T') {
         Stats::setEnabled(true);
     } else if (code == 'S') {
         Py_NoSiteFlag = 1;
@@ -329,7 +327,7 @@ static int main(int argc, char** argv) noexcept {
 
         // Suppress getopt errors so we can throw them ourselves
         opterr = 0;
-        while ((code = getopt(argc, argv, "+:OqdIibpjtrsRSUvnxXEac:FuPTGm:")) != -1) {
+        while ((code = getopt(argc, argv, "+:OqdIibpjtrTRSUvnxXEac:FuPTGm:")) != -1) {
             if (code == 'c') {
                 assert(optarg);
                 command = optarg;

tools/tester.py

@@ -231,7 +231,7 @@ def get_test_options(fn, check_stats, run_memcheck):
         opts.expected = "success"
 
     if opts.collect_stats:
-        opts.jit_args = ['-s'] + opts.jit_args
+        opts.jit_args = ['-T'] + opts.jit_args
 
     return opts