rely on presense or absense of data attribute instead of coerced boolean strings

app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js

@@ -28,11 +28,12 @@ document.addEventListener('DOMContentLoaded', () => {
   const autoDevOpsExtraSettings = document.querySelector('.js-extra-settings');
 
   autoDevOpsSettings.addEventListener('click', event => {
-    const targetData = event.target && event.target.dataset;
-    if (targetData.hideExtraSettings === 'true') {
-      autoDevOpsExtraSettings.classList.add('hidden');
-    } else if (targetData.hideExtraSettings === 'false') {
-      autoDevOpsExtraSettings.classList.remove('hidden');
+    const target = event.target;
+    if (target.classList.contains('js-toggle-extra-settings')) {
+      autoDevOpsExtraSettings.classList.toggle(
+        'hidden',
+        !!(target.dataset && target.dataset.hideExtraSettings),
+      );
     }
   });
 });

app/views/projects/settings/ci_cd/_autodevops_form.html.haml

@@ -13,7 +13,7 @@
             .card.auto-devops-card
               .card-body
                 .form-check
-                  = form.radio_button :enabled, 'true', class: 'form-check-input', data: { hide_extra_settings: false }
+                  = form.radio_button :enabled, 'true', class: 'form-check-input js-toggle-extra-settings'
                   = form.label :enabled_true, class: 'form-check-label' do
                     %strong= s_('CICD|Enable Auto DevOps')
                   .form-text.text-muted
@@ -22,7 +22,7 @@
             .card.auto-devops-card
               .card-body
                 .form-check
-                  = form.radio_button :enabled, '', class: 'form-check-input', data: { hide_extra_settings: false }
+                  = form.radio_button :enabled, '', class: 'form-check-input js-toggle-extra-settings'
                   = form.label :enabled_, class: 'form-check-label' do
                     %strong= s_('CICD|Instance default (%{state})') % { state: "#{Gitlab::CurrentSettings.auto_devops_enabled? ? _('enabled') : _('disabled')}" }
                   .form-text.text-muted
@@ -57,7 +57,7 @@
             .card.auto-devops-card
               .card-body
                 .form-check
-                  = form.radio_button :enabled, 'false', class: 'form-check-input', data: { hide_extra_settings: true }
+                  = form.radio_button :enabled, 'false', class: 'form-check-input js-toggle-extra-settings', data: { hide_extra_settings: true }
                   = form.label :enabled_false, class: 'form-check-label' do
                     %strong= s_('CICD|Disable Auto DevOps')
                   .form-text.text-muted