Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
161e6689
Commit
161e6689
authored
Nov 15, 2018
by
Amit Rathi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Set appropriate RBAC flag for cluster applications
parent
5c275490
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
9 deletions
+8
-9
app/models/clusters/applications/cert_manager.rb
app/models/clusters/applications/cert_manager.rb
+1
-2
lib/gitlab/kubernetes/helm/install_command.rb
lib/gitlab/kubernetes/helm/install_command.rb
+7
-7
No files found.
app/models/clusters/applications/cert_manager.rb
View file @
161e6689
...
...
@@ -40,8 +40,7 @@ module Clusters
def
install_command_flags
[
'--set'
,
'ingressShim.defaultIssuerName=letsencrypt-prod'
]
+
[
'--set'
,
'ingressShim.defaultIssuerKind=ClusterIssuer'
]
+
[
'--set'
,
'rbac.create=false'
]
[
'--set'
,
'ingressShim.defaultIssuerKind=ClusterIssuer'
]
end
private
...
...
lib/gitlab/kubernetes/helm/install_command.rb
View file @
161e6689
...
...
@@ -69,18 +69,18 @@ module Gitlab
name_flag
+
optional_tls_flags
+
optional_version_flag
+
optional_
rbac_create_flag
+
rbac_create_flag
+
namespace_flag
+
value_flag
+
application_flags
end
def
optional_
rbac_create_flag
return
[]
unless
rbac?
# jupyterhub helm chart is using rbac.enabled
# https://github.com/jupyterhub/zero-to-jupyterhub-k8s/tree/master/jupyterhub
%w[--set rbac.create=true,rbac.enabled=true]
def
rbac_create_flag
if
rbac?
%w[--set rbac.create=true,rbac.enabled=true]
else
%w[--set rbac.create=false,rbac.enabled=false]
end
end
def
optional_version_flag
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment