Commit 1810feae authored by Samantha Ming's avatar Samantha Ming

Remove duplicate buttons

parent b46cf429
...@@ -39,30 +39,27 @@ export default { ...@@ -39,30 +39,27 @@ export default {
</script> </script>
<template> <template>
<div class="discussion-with-resolve-btn"> <div class="discussion-with-resolve-btn clearfix">
<reply-placeholder <reply-placeholder
:button-text="s__('MergeRequests|Reply...')" :button-text="s__('MergeRequests|Reply...')"
class="qa-discussion-reply" class="qa-discussion-reply"
@onClick="$emit('showReplyForm')" @onClick="$emit('showReplyForm')"
/> />
<resolve-discussion-button
v-if="discussion.resolvable" <div class="btn-group discussion-actions" role="group">
:is-resolving="isResolving" <div class="btn-group">
:button-title="resolveButtonTitle" <resolve-discussion-button
@onClick="$emit('resolve')" v-if="discussion.resolvable"
/> :is-resolving="isResolving"
<div v-if="discussion.resolvable" class="btn-group discussion-actions ml-sm-2" role="group"> :button-title="resolveButtonTitle"
<resolve-with-issue-button v-if="resolveWithIssuePath" :url="resolveWithIssuePath" /> @onClick="$emit('resolve')"
<jump-to-next-discussion-button />
v-if="shouldShowJumpToNextDiscussion" </div>
@onClick="$emit('jumpToNextDiscussion')"
/>
<resolve-with-issue-button <resolve-with-issue-button
v-if="discussion.resolvable && resolveWithIssuePath" v-if="discussion.resolvable && resolveWithIssuePath"
:url="resolveWithIssuePath" :url="resolveWithIssuePath"
/> />
</div> </div>
<div <div
v-if="discussion.resolvable && shouldShowJumpToNextDiscussion" v-if="discussion.resolvable && shouldShowJumpToNextDiscussion"
class="btn-group discussion-actions ml-sm-2" class="btn-group discussion-actions ml-sm-2"
......
---
title: Remove duplicate buttons in diff discussion
merge_request: 30757
author:
type: fixed
...@@ -362,14 +362,14 @@ describe 'Merge request > User resolves diff notes and threads', :js do ...@@ -362,14 +362,14 @@ describe 'Merge request > User resolves diff notes and threads', :js do
end end
end end
it 'shows jump to next thread button except on last thread' do it 'shows jump to next discussion button on all discussions' do
wait_for_requests wait_for_requests
all_discussion_replies = page.all('.discussion-reply-holder') all_discussion_replies = page.all('.discussion-reply-holder')
expect(all_discussion_replies.count).to eq(2) expect(all_discussion_replies.count).to eq(2)
expect(all_discussion_replies.first.all('.discussion-next-btn').count).to eq(2) expect(all_discussion_replies.first.all('.discussion-next-btn').count).to eq(1)
expect(all_discussion_replies.last.all('.discussion-next-btn').count).to eq(2) expect(all_discussion_replies.last.all('.discussion-next-btn').count).to eq(1)
end end
it 'displays next thread even if hidden' do it 'displays next thread even if hidden' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment