Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
1810feae
Commit
1810feae
authored
Jul 15, 2019
by
Samantha Ming
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove duplicate buttons
parent
b46cf429
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
17 deletions
+19
-17
app/assets/javascripts/notes/components/discussion_actions.vue
...ssets/javascripts/notes/components/discussion_actions.vue
+11
-14
changelogs/unreleased/64160-fix-duplicate-buttons.yml
changelogs/unreleased/64160-fix-duplicate-buttons.yml
+5
-0
spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb
.../user_resolves_diff_notes_and_discussions_resolve_spec.rb
+3
-3
No files found.
app/assets/javascripts/notes/components/discussion_actions.vue
View file @
1810feae
...
@@ -39,30 +39,27 @@ export default {
...
@@ -39,30 +39,27 @@ export default {
</
script
>
</
script
>
<
template
>
<
template
>
<div
class=
"discussion-with-resolve-btn"
>
<div
class=
"discussion-with-resolve-btn
clearfix
"
>
<reply-placeholder
<reply-placeholder
:button-text=
"s__('MergeRequests|Reply...')"
:button-text=
"s__('MergeRequests|Reply...')"
class=
"qa-discussion-reply"
class=
"qa-discussion-reply"
@
onClick=
"$emit('showReplyForm')"
@
onClick=
"$emit('showReplyForm')"
/>
/>
<resolve-discussion-button
v-if=
"discussion.resolvable"
<div
class=
"btn-group discussion-actions"
role=
"group"
>
:is-resolving=
"isResolving"
<div
class=
"btn-group"
>
:button-title=
"resolveButtonTitle"
<resolve-discussion-button
@
onClick=
"$emit('resolve')"
v-if=
"discussion.resolvable"
/>
:is-resolving=
"isResolving"
<div
v-if=
"discussion.resolvable"
class=
"btn-group discussion-actions ml-sm-2"
role=
"group"
>
:button-title=
"resolveButtonTitle"
<resolve-with-issue-button
v-if=
"resolveWithIssuePath"
:url=
"resolveWithIssuePath"
/>
@
onClick=
"$emit('resolve')"
<jump-to-next-discussion-button
/>
v-if=
"shouldShowJumpToNextDiscussion"
</div>
@
onClick=
"$emit('jumpToNextDiscussion')"
/>
<resolve-with-issue-button
<resolve-with-issue-button
v-if=
"discussion.resolvable && resolveWithIssuePath"
v-if=
"discussion.resolvable && resolveWithIssuePath"
:url=
"resolveWithIssuePath"
:url=
"resolveWithIssuePath"
/>
/>
</div>
</div>
<div
<div
v-if=
"discussion.resolvable && shouldShowJumpToNextDiscussion"
v-if=
"discussion.resolvable && shouldShowJumpToNextDiscussion"
class=
"btn-group discussion-actions ml-sm-2"
class=
"btn-group discussion-actions ml-sm-2"
...
...
changelogs/unreleased/64160-fix-duplicate-buttons.yml
0 → 100644
View file @
1810feae
---
title
:
Remove duplicate buttons in diff discussion
merge_request
:
30757
author
:
type
:
fixed
spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb
View file @
1810feae
...
@@ -362,14 +362,14 @@ describe 'Merge request > User resolves diff notes and threads', :js do
...
@@ -362,14 +362,14 @@ describe 'Merge request > User resolves diff notes and threads', :js do
end
end
end
end
it
'shows jump to next
thread button except on last thread
'
do
it
'shows jump to next
discussion button on all discussions
'
do
wait_for_requests
wait_for_requests
all_discussion_replies
=
page
.
all
(
'.discussion-reply-holder'
)
all_discussion_replies
=
page
.
all
(
'.discussion-reply-holder'
)
expect
(
all_discussion_replies
.
count
).
to
eq
(
2
)
expect
(
all_discussion_replies
.
count
).
to
eq
(
2
)
expect
(
all_discussion_replies
.
first
.
all
(
'.discussion-next-btn'
).
count
).
to
eq
(
2
)
expect
(
all_discussion_replies
.
first
.
all
(
'.discussion-next-btn'
).
count
).
to
eq
(
1
)
expect
(
all_discussion_replies
.
last
.
all
(
'.discussion-next-btn'
).
count
).
to
eq
(
2
)
expect
(
all_discussion_replies
.
last
.
all
(
'.discussion-next-btn'
).
count
).
to
eq
(
1
)
end
end
it
'displays next thread even if hidden'
do
it
'displays next thread even if hidden'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment