Commit 199e31eb authored by Grzegorz Bizon's avatar Grzegorz Bizon

Extend specs for detailed build extended statuses

parent 160ffb68
...@@ -9,7 +9,8 @@ module Gitlab ...@@ -9,7 +9,8 @@ module Gitlab
Status::Build::Canceled, Status::Build::Canceled,
Status::Build::Created, Status::Build::Created,
Status::Build::Pending, Status::Build::Pending,
Status::Build::Skipped], Status::Build::Skipped,
Status::Build::Empty],
[Status::Build::Cancelable, [Status::Build::Cancelable,
Status::Build::Retryable], Status::Build::Retryable],
[Status::Build::Failed], [Status::Build::Failed],
...@@ -17,8 +18,7 @@ module Gitlab ...@@ -17,8 +18,7 @@ module Gitlab
Status::Build::Play, Status::Build::Play,
Status::Build::Stop], Status::Build::Stop],
[Status::Build::Action], [Status::Build::Action],
[Status::Build::Retried], [Status::Build::Retried]]
[Status::Build::Empty]]
end end
def self.common_helpers def self.common_helpers
......
...@@ -38,4 +38,10 @@ describe Gitlab::Ci::Status::Build::Common do ...@@ -38,4 +38,10 @@ describe Gitlab::Ci::Status::Build::Common do
expect(subject.details_path).to include "jobs/#{build.id}" expect(subject.details_path).to include "jobs/#{build.id}"
end end
end end
describe '#illustration' do
it 'provides a fallback empty state illustration' do
expect(subject.illustration).not_to be_empty
end
end
end end
require 'spec_helper'
describe Gitlab::Ci::Status::Build::Empty do
let(:build) { create(:ci_build, :running) }
let(:status) { double('core status') }
let(:user) { double('user') }
subject { described_class.new(status) }
describe '#illustration' do
it 'provides an empty state illustration' do
expect(subject.illustration).not_to be_empty
end
end
describe '.matches?' do
subject { described_class.matches?(build, user) }
context 'when a build has trace' do
let(:build) { create(:ci_build, :trace_artifact) }
it { is_expected.to be_falsy }
end
context 'with a build that has not been retried' do
let(:build) { create(:ci_build, :running) }
it { is_expected.to be_truthy }
end
end
end
...@@ -75,7 +75,9 @@ describe Gitlab::Ci::Status::Build::Factory do ...@@ -75,7 +75,9 @@ describe Gitlab::Ci::Status::Build::Factory do
it 'matches correct extended statuses' do it 'matches correct extended statuses' do
expect(factory.extended_statuses) expect(factory.extended_statuses)
.to eq [Gitlab::Ci::Status::Build::Retryable, Gitlab::Ci::Status::Build::Failed] .to eq [Gitlab::Ci::Status::Build::Empty,
Gitlab::Ci::Status::Build::Retryable,
Gitlab::Ci::Status::Build::Failed]
end end
it 'fabricates a failed build status' do it 'fabricates a failed build status' do
...@@ -94,7 +96,7 @@ describe Gitlab::Ci::Status::Build::Factory do ...@@ -94,7 +96,7 @@ describe Gitlab::Ci::Status::Build::Factory do
end end
context 'when build is allowed to fail' do context 'when build is allowed to fail' do
let(:build) { create(:ci_build, :failed, :allowed_to_fail) } let(:build) { create(:ci_build, :failed, :allowed_to_fail, :trace_artifact) }
it 'matches correct core status' do it 'matches correct core status' do
expect(factory.core_status).to be_a Gitlab::Ci::Status::Failed expect(factory.core_status).to be_a Gitlab::Ci::Status::Failed
...@@ -160,7 +162,8 @@ describe Gitlab::Ci::Status::Build::Factory do ...@@ -160,7 +162,8 @@ describe Gitlab::Ci::Status::Build::Factory do
it 'matches correct extended statuses' do it 'matches correct extended statuses' do
expect(factory.extended_statuses) expect(factory.extended_statuses)
.to eq [Gitlab::Ci::Status::Build::Cancelable] .to eq [Gitlab::Ci::Status::Build::Empty,
Gitlab::Ci::Status::Build::Cancelable]
end end
it 'fabricates a canceable build status' do it 'fabricates a canceable build status' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment