Commit 1b2de25d authored by Sean McGivern's avatar Sean McGivern

Don't fail the pipeline when a colon-emoji is used

A colon-emoji like 💯 can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
parent 70a717da
...@@ -163,10 +163,10 @@ def lint_commit(commit) ...@@ -163,10 +163,10 @@ def lint_commit(commit)
end end
if emoji_checker.includes_emoji?(commit.message) if emoji_checker.includes_emoji?(commit.message)
fail_commit( warn_commit(
commit, commit,
'Avoid the use of Markdown Emoji such as `:+1:`. ' \ 'Avoid the use of Markdown Emoji such as `:+1:`. ' \
'These add no value to the commit message, ' \ 'These add limited value to the commit message, ' \
'and are displayed as plain text outside of GitLab' 'and are displayed as plain text outside of GitLab'
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment