Refactor out duplication in runner_policy.rb

1cfa5ed0 · Dylan Griffith · 983bc6b1 · 1cfa5ed0
Commit 1cfa5ed0 authored May 16, 2018 by Dylan Griffith
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 4 deletions

app/policies/ci/runner_policy.rb app/policies/ci/runner_policy.rb +8 -4

No files found.
--- a/app/policies/ci/runner_policy.rb
+++ b/app/policies/ci/runner_policy.rb
@@ -6,10 +6,14 @@ module Ci
    condition(:owned_runner) { @user.ci_owned_runners.exists?(@subject.id) }

    rule { anonymous }.prevent_all
-    rule { admin | owned_runner }.enable :assign_runner
-    rule { admin | owned_runner }.enable :read_runner
-    rule { admin | owned_runner }.enable :update_runner
-    rule { admin | owned_runner }.enable :delete_runner
+
+    rule { admin | owned_runner }.policy do
+      enable :assign_runner
+      enable :read_runner
+      enable :update_runner
+      enable :delete_runner
+    end
+
    rule { ~admin & locked }.prevent :assign_runner
  end
 end