Commit 20ed08ed authored by Douwe Maan's avatar Douwe Maan

Merge branch 'rs-note-model-cleanup' into 'master'

Minor Note model cleanup

Remove `Note#noteable_type_name`

This method was added in Dec 2012, its single use was removed two days
later, and it's been there ever since.

---

Remove `Note#system?` "override"

This method was duplicating default Rails behavior.

See merge request !3104
parents b8a1f1c4 1b27c3c5
...@@ -323,10 +323,6 @@ class Note < ActiveRecord::Base ...@@ -323,10 +323,6 @@ class Note < ActiveRecord::Base
noteable noteable
end end
def noteable_type_name
noteable_type.downcase if noteable_type.present?
end
# FIXME: Hack for polymorphic associations with STI # FIXME: Hack for polymorphic associations with STI
# For more information visit http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#label-Polymorphic+Associations # For more information visit http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#label-Polymorphic+Associations
def noteable_type=(noteable_type) def noteable_type=(noteable_type)
...@@ -346,10 +342,6 @@ class Note < ActiveRecord::Base ...@@ -346,10 +342,6 @@ class Note < ActiveRecord::Base
Event.reset_event_cache_for(self) Event.reset_event_cache_for(self)
end end
def system?
read_attribute(:system)
end
def downvote? def downvote?
is_award && note == "thumbsdown" is_award && note == "thumbsdown"
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment