Merge branch 'frozen-string-enable-app-uploaders' into 'master'

Enable frozen string in apps/uploaders/*.rb

See merge request gitlab-org/gitlab-ce!20382

app/uploaders/attachment_uploader.rb

+# frozen_string_literal: true
+
 class AttachmentUploader < GitlabUploader
   include RecordsUploads::Concern
   include ObjectStorage::Concern

app/uploaders/avatar_uploader.rb

+# frozen_string_literal: true
+
 class AvatarUploader < GitlabUploader
   include UploaderHelper
   include RecordsUploads::Concern

app/uploaders/favicon_uploader.rb

+# frozen_string_literal: true
+
 class FaviconUploader < AttachmentUploader
   EXTENSION_WHITELIST = %w[png ico].freeze
 

app/uploaders/file_mover.rb

+# frozen_string_literal: true
+
 class FileMover
   attr_reader :secret, :file_name, :model, :update_field
 

app/uploaders/file_uploader.rb

+# frozen_string_literal: true
+
 # This class breaks the actual CarrierWave concept.
 # Every uploader should use a base_dir that is model agnostic so we can build
 # back URLs from base_dir-relative paths saved in the `Upload` model.
@@ -117,7 +119,7 @@ class FileUploader < GitlabUploader
   end
 
   def markdown_link
-    markdown = "[#{markdown_name}](#{secure_url})"
+    markdown = +"[#{markdown_name}](#{secure_url})"
     markdown.prepend("!") if image_or_video? || dangerous?
     markdown
   end

app/uploaders/gitlab_uploader.rb

+# frozen_string_literal: true
+
 class GitlabUploader < CarrierWave::Uploader::Base
   class_attribute :options
 

app/uploaders/job_artifact_uploader.rb

+# frozen_string_literal: true
+
 class JobArtifactUploader < GitlabUploader
   extend Workhorse::UploadPath
   include ObjectStorage::Concern

app/uploaders/legacy_artifact_uploader.rb

+# frozen_string_literal: true
+
 class LegacyArtifactUploader < GitlabUploader
   extend Workhorse::UploadPath
   include ObjectStorage::Concern

app/uploaders/lfs_object_uploader.rb

+# frozen_string_literal: true
+
 class LfsObjectUploader < GitlabUploader
   extend Workhorse::UploadPath
   include ObjectStorage::Concern

app/uploaders/namespace_file_uploader.rb

+# frozen_string_literal: true
+
 class NamespaceFileUploader < FileUploader
   # Re-Override
   def self.root

app/uploaders/object_storage.rb

+# frozen_string_literal: true
+
 require 'fog/aws'
 require 'carrierwave/storage/fog'
 

app/uploaders/personal_file_uploader.rb

+# frozen_string_literal: true
+
 class PersonalFileUploader < FileUploader
   # Re-Override
   def self.root

app/uploaders/records_uploads.rb

+# frozen_string_literal: true
+
 module RecordsUploads
   module Concern
     extend ActiveSupport::Concern

app/uploaders/uploader_helper.rb

+# frozen_string_literal: true
+
 # Extra methods for uploader
 module UploaderHelper
   IMAGE_EXT = %w[png jpg jpeg gif bmp tiff ico].freeze

app/uploaders/workhorse.rb

+# frozen_string_literal: true
+
 module Workhorse
   module UploadPath
     def workhorse_upload_path

changelogs/unreleased/frozen-string-enable-app-uploaders.yml

+---
+title: Enable frozen string in apps/validators/*.rb
+merge_request: 20382
+author: gfyoung
+type: other