Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
2f05e34b
Commit
2f05e34b
authored
Aug 16, 2018
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add test for simple ciricular dependency in `extends`
parent
2c41fbb1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
2 deletions
+20
-2
spec/lib/gitlab/ci/config/extendable/collection_spec.rb
spec/lib/gitlab/ci/config/extendable/collection_spec.rb
+20
-2
No files found.
spec/lib/gitlab/ci/config/extendable/collection_spec.rb
View file @
2f05e34b
...
@@ -116,8 +116,7 @@ describe Gitlab::Ci::Config::Extendable::Collection do
...
@@ -116,8 +116,7 @@ describe Gitlab::Ci::Config::Extendable::Collection do
end
end
end
end
pending
'when invalid `extends` is specified'
context
'when nested circular dependecy has been detected'
do
context
'when circular dependecy has been detected'
do
let
(
:hash
)
do
let
(
:hash
)
do
{
{
test:
{
test:
{
...
@@ -145,5 +144,24 @@ describe Gitlab::Ci::Config::Extendable::Collection do
...
@@ -145,5 +144,24 @@ describe Gitlab::Ci::Config::Extendable::Collection do
.
to
raise_error
(
described_class
::
CircularDependencyError
)
.
to
raise_error
(
described_class
::
CircularDependencyError
)
end
end
end
end
context
'when circular dependecy to self has been detected'
do
let
(
:hash
)
do
{
test:
{
extends:
'test'
,
script:
'ls'
,
only:
{
refs:
%w[master]
}
}
}
end
it
'raises an error'
do
expect
{
subject
.
extend!
}
.
to
raise_error
(
described_class
::
CircularDependencyError
)
end
end
pending
'when invalid `extends` is specified'
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment