Commit 2fd334b8 authored by Luke Bennett's avatar Luke Bennett

Fix group labels list

parent bd47118e
...@@ -262,8 +262,6 @@ ...@@ -262,8 +262,6 @@
} }
.label-list-item { .label-list-item {
overflow-x: scroll;
.content-list &:before, .content-list &:before,
.content-list &:after { .content-list &:after {
content: none; content: none;
......
...@@ -9,11 +9,11 @@ class Groups::LabelsController < Groups::ApplicationController ...@@ -9,11 +9,11 @@ class Groups::LabelsController < Groups::ApplicationController
respond_to :html respond_to :html
def index def index
@prioritized_labels = @available_labels.prioritized(@group) @labels = @group.labels.page(params[:page])
@labels = @available_labels.unprioritized(@group).page(params[:page])
respond_to do |format| respond_to do |format|
format.html format.html do
end
format.json do format.json do
render json: LabelSerializer.new.represent_appearance(@available_labels) render json: LabelSerializer.new.represent_appearance(@available_labels)
end end
......
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
- page_title "Labels" - page_title "Labels"
- can_admin_label = can?(current_user, :admin_label, @group) - can_admin_label = can?(current_user, :admin_label, @group)
- hide_class = '' - hide_class = ''
- hide = @available_labels.empty? || (params[:page].present? && params[:page] != '1')
- if can_admin_label - if can_admin_label
- content_for(:header_content) do - content_for(:header_content) do
...@@ -9,7 +10,7 @@ ...@@ -9,7 +10,7 @@
= link_to new_group_label_path(@group), class: "btn btn-new" do = link_to new_group_label_path(@group), class: "btn btn-new" do
New label New label
- if @labels.exists? || @prioritized_labels.exists? - if @labels.exists?
#promote-label-modal #promote-label-modal
%div{ class: container_class } %div{ class: container_class }
.top-area.adjust .top-area.adjust
...@@ -19,24 +20,12 @@ ...@@ -19,24 +20,12 @@
Star a label to make it a priority label. Order the prioritized labels to change their relative priority, by dragging. Star a label to make it a priority label. Order the prioritized labels to change their relative priority, by dragging.
.labels-container.prepend-top-5 .labels-container.prepend-top-5
- if can_admin_label .other-labels
-# Only show it in the first page - if can_admin_label
- hide = @available_labels.empty? || (params[:page].present? && params[:page] != '1') %h5{ class: ('hide' if hide) } Labels
.prioritized-labels{ class: ('hide' if hide) } %ul.content-list.manage-labels-list.js-other-labels
%h5.prepend-top-0 Prioritized Labels = render partial: 'shared/label', subject: @group, collection: @labels, as: :label
%ul.content-list.manage-labels-list.js-prioritized-labels = paginate @labels, theme: 'gitlab'
#js-priority-labels-empty-state.priority-labels-empty-state{ class: "#{'hidden' unless @prioritized_labels.empty?}" }
= render 'shared/empty_states/priority_labels'
- if @prioritized_labels.present?
= render partial: 'shared/label', subject: @group, collection: @prioritized_labels, as: :label
- if @labels.present?
.other-labels
- if can_admin_label
%h5{ class: ('hide' if hide) } Other Labels
%ul.content-list.manage-labels-list.js-other-labels
= render partial: 'shared/label', subject: @group, collection: @labels, as: :label
= paginate @labels, theme: 'gitlab'
- else - else
= render 'shared/empty_states/labels' = render 'shared/empty_states/labels'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment