Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
3129dd50
Commit
3129dd50
authored
Feb 15, 2017
by
Stan Hu
Committed by
Dmitriy Zaporozhets
Feb 27, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make nested groups deletion synchronous to avoid potential race
parent
8b855eaf
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
1 deletion
+2
-1
app/services/groups/destroy_service.rb
app/services/groups/destroy_service.rb
+2
-1
No files found.
app/services/groups/destroy_service.rb
View file @
3129dd50
...
@@ -18,7 +18,8 @@ module Groups
...
@@ -18,7 +18,8 @@ module Groups
end
end
group
.
children
.
each
do
|
group
|
group
.
children
.
each
do
|
group
|
DestroyService
.
new
(
group
,
current_user
).
async_execute
# This needs to be synchronous since the namespace gets destroyed below
DestroyService
.
new
(
group
,
current_user
).
execute
end
end
group
.
really_destroy!
group
.
really_destroy!
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment