Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
325a5baf
Commit
325a5baf
authored
Oct 19, 2016
by
Paco Guzman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simpler arguments passed to named_route on toggle_award_url helper method
parent
44f718c9
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
CHANGELOG.md
CHANGELOG.md
+1
-0
app/helpers/award_emoji_helper.rb
app/helpers/award_emoji_helper.rb
+2
-2
No files found.
CHANGELOG.md
View file @
325a5baf
Please view this file on the master branch, on stable branches it's out of date.
Please view this file on the master branch, on stable branches it's out of date.
## 8.14.0 (2016-11-22)
## 8.14.0 (2016-11-22)
-
Simpler arguments passed to named_route on toggle_award_url helper method
## 8.13.0 (2016-10-22)
## 8.13.0 (2016-10-22)
...
...
app/helpers/award_emoji_helper.rb
View file @
325a5baf
...
@@ -3,8 +3,8 @@ module AwardEmojiHelper
...
@@ -3,8 +3,8 @@ module AwardEmojiHelper
return
url_for
([
:toggle_award_emoji
,
awardable
])
unless
@project
return
url_for
([
:toggle_award_emoji
,
awardable
])
unless
@project
if
awardable
.
is_a?
(
Note
)
if
awardable
.
is_a?
(
Note
)
# We render a list of notes very frequently and calling the specific method is a lot faster than the generic one (
6
.5x)
# We render a list of notes very frequently and calling the specific method is a lot faster than the generic one (
4
.5x)
toggle_award_emoji_namespace_project_note_url
(
namespace_id:
@project
.
namespace
,
project_id:
@project
,
id:
awardable
.
id
)
toggle_award_emoji_namespace_project_note_url
(
@project
.
namespace
,
@project
,
awardable
.
id
)
else
else
url_for
([
:toggle_award_emoji
,
@project
.
namespace
.
becomes
(
Namespace
),
@project
,
awardable
])
url_for
([
:toggle_award_emoji
,
@project
.
namespace
.
becomes
(
Namespace
),
@project
,
awardable
])
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment