Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
35cea54a
Commit
35cea54a
authored
Aug 19, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed keyboard shortcuts not working on issue boards
Closes #21071
parent
12fe6a6f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
0 deletions
+15
-0
app/assets/javascripts/dispatcher.js
app/assets/javascripts/dispatcher.js
+3
-0
spec/features/boards/boards_spec.rb
spec/features/boards/boards_spec.rb
+12
-0
No files found.
app/assets/javascripts/dispatcher.js
View file @
35cea54a
...
@@ -20,6 +20,9 @@
...
@@ -20,6 +20,9 @@
path
=
page
.
split
(
'
:
'
);
path
=
page
.
split
(
'
:
'
);
shortcut_handler
=
null
;
shortcut_handler
=
null
;
switch
(
page
)
{
switch
(
page
)
{
case
'
projects:boards:show
'
:
shortcut_handler
=
new
ShortcutsNavigation
();
break
;
case
'
projects:issues:index
'
:
case
'
projects:issues:index
'
:
Issuable
.
init
();
Issuable
.
init
();
new
IssuableBulkActions
();
new
IssuableBulkActions
();
...
...
spec/features/boards/boards_spec.rb
View file @
35cea54a
...
@@ -572,6 +572,18 @@ describe 'Issue Boards', feature: true, js: true do
...
@@ -572,6 +572,18 @@ describe 'Issue Boards', feature: true, js: true do
end
end
end
end
context
'keyboard shortcuts'
do
before
do
visit
namespace_project_board_path
(
project
.
namespace
,
project
)
wait_for_vue_resource
end
it
'allows user to use keyboard shortcuts'
do
find
(
'.boards-list'
).
native
.
send_keys
(
'i'
)
expect
(
page
).
to
have_content
(
'New Issue'
)
end
end
context
'signed out user'
do
context
'signed out user'
do
before
do
before
do
logout
logout
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment