Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
43c712f5
Commit
43c712f5
authored
Oct 02, 2017
by
Nick Thomas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Whitelist authorized_keys.lock in the gitlab:check rake task
parent
aa445119
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
changelogs/unreleased/38635-fix-gitlab-check-git-ssh-config.yml
...logs/unreleased/38635-fix-gitlab-check-git-ssh-config.yml
+5
-0
lib/system_check/app/git_user_default_ssh_config_check.rb
lib/system_check/app/git_user_default_ssh_config_check.rb
+1
-0
spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb
...ystem_check/app/git_user_default_ssh_config_check_spec.rb
+6
-1
No files found.
changelogs/unreleased/38635-fix-gitlab-check-git-ssh-config.yml
0 → 100644
View file @
43c712f5
---
title
:
Whitelist authorized_keys.lock in the gitlab:check rake task
merge_request
:
14624
author
:
type
:
fixed
lib/system_check/app/git_user_default_ssh_config_check.rb
View file @
43c712f5
...
@@ -5,6 +5,7 @@ module SystemCheck
...
@@ -5,6 +5,7 @@ module SystemCheck
# whitelisted as it may change the SSH client's behaviour dramatically.
# whitelisted as it may change the SSH client's behaviour dramatically.
WHITELIST
=
%w[
WHITELIST
=
%w[
authorized_keys
authorized_keys
authorized_keys.lock
authorized_keys2
authorized_keys2
known_hosts
known_hosts
]
.
freeze
]
.
freeze
...
...
spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb
View file @
43c712f5
...
@@ -16,7 +16,12 @@ describe SystemCheck::App::GitUserDefaultSSHConfigCheck do
...
@@ -16,7 +16,12 @@ describe SystemCheck::App::GitUserDefaultSSHConfigCheck do
end
end
it
'only whitelists safe files'
do
it
'only whitelists safe files'
do
expect
(
described_class
::
WHITELIST
).
to
contain_exactly
(
'authorized_keys'
,
'authorized_keys2'
,
'known_hosts'
)
expect
(
described_class
::
WHITELIST
).
to
contain_exactly
(
'authorized_keys'
,
'authorized_keys2'
,
'authorized_keys.lock'
,
'known_hosts'
)
end
end
describe
'#skip?'
do
describe
'#skip?'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment