Use `bind` instead of currying to access outer context

45220e31 · Kushal Pandya · 2b6b28da · 45220e31
Commit 45220e31 authored Dec 12, 2016 by Kushal Pandya
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 9 deletions

app/assets/javascripts/build.js app/assets/javascripts/build.js +7 -9

No files found.
--- a/app/assets/javascripts/build.js
+++ b/app/assets/javascripts/build.js
@@ -86,15 +86,13 @@
      return $.ajax({
        url: this.buildUrl,
        dataType: 'json',
-        success: (function(_this) {
+        success: function(buildData) {
-          return function(buildData) {
+          $('.js-build-output').html(buildData.trace_html);
-            $('.js-build-output').html(buildData.trace_html);
+          if (removeRefreshStatuses.indexOf(buildData.status) >= 0) {
-            if (removeRefreshStatuses.indexOf(buildData.status) >= 0) {
+            this.initScrollMonitor();
-              _this.initScrollMonitor();
+            return $('.js-build-refresh').remove();
-              return $('.js-build-refresh').remove();
+          }
-            }
+        }.bind(this)
-          };
-        })(this)
      });
    };