Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
4792eb7a
Commit
4792eb7a
authored
Feb 13, 2017
by
Nur Rony
Committed by
Filipa Lacerda
Feb 23, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixes job dropdown action button error
parent
f106ad51
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
6 deletions
+14
-6
app/assets/javascripts/vue_pipelines_index/stage.js.es6
app/assets/javascripts/vue_pipelines_index/stage.js.es6
+10
-6
changelogs/unreleased/27530-fix-job-dropdown-pipeline-console-error.yml
...eleased/27530-fix-job-dropdown-pipeline-console-error.yml
+4
-0
No files found.
app/assets/javascripts/vue_pipelines_index/stage.js.es6
View file @
4792eb7a
...
@@ -37,15 +37,19 @@
...
@@ -37,15 +37,19 @@
return flash;
return flash;
});
});
},
},
/**
* When the user right clicks or cmd/ctrl + click in the job name or action icon,
* the dropdown should not be closed and the link should open in another tab.
* If the target is a svg we stop propagation in order to prevent
* the default behavior of the dropdown.
*/
keepGraph(e) {
keepGraph(e) {
const { target } = e;
const { target } = e;
const svgClassName = target.getAttribute('class');
const svgParentClassName = target.parentElement && target.parentElement.getAttribute('class');
if (target.className.indexOf('js-ci-action-icon') >= 0) return null;
if (svgClassName && svgClassName.indexOf('js-ci-action-icon') >= 0) return null;
if (svgParentClassName && svgParentClassName.indexOf('js-ci-action-icon') >= 0) return null;
if (
target.parentElement &&
(target.parentElement.className.indexOf('js-ci-action-icon') >= 0)
) return null;
return e.stopPropagation();
return e.stopPropagation();
},
},
...
...
changelogs/unreleased/27530-fix-job-dropdown-pipeline-console-error.yml
0 → 100644
View file @
4792eb7a
---
title
:
Fixes job dropdown action throws error in js console
merge_request
:
9182
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment