Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
49831b53
Commit
49831b53
authored
Jan 25, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix project name label's for reference in project settings
parent
73c54366
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
3 deletions
+7
-3
app/views/projects/edit.html.haml
app/views/projects/edit.html.haml
+1
-1
changelogs/unreleased/27259-label-for-references-the-wrong-associated-text-input.yml
...-label-for-references-the-wrong-associated-text-input.yml
+4
-0
spec/features/projects/project_settings_spec.rb
spec/features/projects/project_settings_spec.rb
+2
-2
No files found.
app/views/projects/edit.html.haml
View file @
49831b53
...
@@ -9,7 +9,7 @@
...
@@ -9,7 +9,7 @@
%fieldset
.append-bottom-0
%fieldset
.append-bottom-0
.row
.row
.form-group.col-md-9
.form-group.col-md-9
=
f
.
label
:name
,
class:
'label-light'
do
=
f
.
label
:name
,
class:
'label-light'
,
for:
'project_name_edit'
do
Project name
Project name
=
f
.
text_field
:name
,
class:
"form-control"
,
id:
"project_name_edit"
=
f
.
text_field
:name
,
class:
"form-control"
,
id:
"project_name_edit"
...
...
changelogs/unreleased/27259-label-for-references-the-wrong-associated-text-input.yml
0 → 100644
View file @
49831b53
---
title
:
Fix project name label's for reference in project settings
merge_request
:
8795
author
:
spec/features/projects/project_settings_spec.rb
View file @
49831b53
...
@@ -37,7 +37,7 @@ describe 'Edit Project Settings', feature: true do
...
@@ -37,7 +37,7 @@ describe 'Edit Project Settings', feature: true do
it
'shows errors for invalid project path/name'
do
it
'shows errors for invalid project path/name'
do
visit
edit_namespace_project_path
(
project
.
namespace
,
project
)
visit
edit_namespace_project_path
(
project
.
namespace
,
project
)
fill_in
'
Project
name'
,
with:
'foo&bar'
fill_in
'
project_
name'
,
with:
'foo&bar'
fill_in
'Path'
,
with:
'foo&bar'
fill_in
'Path'
,
with:
'foo&bar'
click_button
'Rename project'
click_button
'Rename project'
...
@@ -53,7 +53,7 @@ describe 'Edit Project Settings', feature: true do
...
@@ -53,7 +53,7 @@ describe 'Edit Project Settings', feature: true do
it
'shows error for invalid project name'
do
it
'shows error for invalid project name'
do
visit
edit_namespace_project_path
(
project
.
namespace
,
project
)
visit
edit_namespace_project_path
(
project
.
namespace
,
project
)
fill_in
'
Project
name'
,
with:
'🚀 foo bar ☁️'
fill_in
'
project_
name'
,
with:
'🚀 foo bar ☁️'
click_button
'Rename project'
click_button
'Rename project'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment