Commit 52ab33a3 authored by Sean McGivern's avatar Sean McGivern

Expire commit view partial after a day

We rarely use Russian-doll caching in views, and when we do, it's
typically with a naturally-invalidating key. In the case of the commit
partial, though, the author lookup isn't part of the cache key - because
we're not going to use the state of the users table - and so a new email
address can take up to two weeks to show against the commits list.

Limiting this to a day still caches the partial for a healthy amount of
time, without as bad a worst case scenario.
parent ee61c403
...@@ -30,6 +30,7 @@ v 8.12.0 (unreleased) ...@@ -30,6 +30,7 @@ v 8.12.0 (unreleased)
- Added tests for diff notes - Added tests for diff notes
- Add a button to download latest successful artifacts for branches and tags !5142 - Add a button to download latest successful artifacts for branches and tags !5142
- Remove redundant pipeline tooltips (ClemMakesApps) - Remove redundant pipeline tooltips (ClemMakesApps)
- Expire commit info views after one day, instead of two weeks, to allow for user email updates
- Add delimiter to project stars and forks count (ClemMakesApps) - Add delimiter to project stars and forks count (ClemMakesApps)
- Fix badge count alignment (ClemMakesApps) - Fix badge count alignment (ClemMakesApps)
- Fix branch title trailing space on hover (ClemMakesApps) - Fix branch title trailing space on hover (ClemMakesApps)
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
- cache_key = [project.path_with_namespace, commit.id, current_application_settings, note_count] - cache_key = [project.path_with_namespace, commit.id, current_application_settings, note_count]
- cache_key.push(commit.status) if commit.status - cache_key.push(commit.status) if commit.status
= cache(cache_key) do = cache(cache_key, expires_in: 1.day) do
%li.commit.js-toggle-container{ id: "commit-#{commit.short_id}" } %li.commit.js-toggle-container{ id: "commit-#{commit.short_id}" }
= author_avatar(commit, size: 36) = author_avatar(commit, size: 36)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment