Merge branch 'winh-boards-helper' into 'master'

Move current issue board serialization to core (CE-backport)

See merge request gitlab-org/gitlab-ce!30507

app/helpers/boards_helper.rb

@@ -99,7 +99,11 @@ module BoardsHelper
     recent_project_boards_path(@project) if current_board_parent.is_a?(Project)
   end
 
+  def serializer
+    CurrentBoardSerializer.new
+  end
+
   def current_board_json
-    board.to_json
+    serializer.represent(board).as_json
   end
 end

app/serializers/current_board_entity.rb

+# frozen_string_literal: true
+
+class CurrentBoardEntity < Grape::Entity
+  expose :id
+  expose :name
+end

app/serializers/current_board_serializer.rb

+# frozen_string_literal: true
+
+class CurrentBoardSerializer < BaseSerializer
+  entity CurrentBoardEntity
+end

spec/fixtures/api/schemas/current-board.json

+{
+  "type": "object",
+  "allOf": [
+    { "$ref": "board.json" },
+    {
+      "required" : [
+        "id",
+        "name"
+      ],
+      "properties": {
+        "id": { "type": "integer" },
+        "name": { "type": "string" }
+      }
+    }
+  ]
+}

spec/helpers/boards_helper_spec.rb

 require 'spec_helper'
 
 describe BoardsHelper do
+  set(:project) { create(:project) }
+
   describe '#build_issue_link_base' do
     context 'project board' do
       it 'returns correct path for project board' do
-        @project = create(:project)
+        @project = project
         @board = create(:board, project: @project)
 
         expect(build_issue_link_base).to eq("/#{@project.namespace.path}/#{@project.path}/issues")
@@ -31,7 +33,6 @@ describe BoardsHelper do
 
   describe '#board_data' do
     let(:user) { create(:user) }
-    let(:project) { create(:project) }
     let(:board) { create(:board, project: project) }
 
     before do
@@ -46,4 +47,15 @@ describe BoardsHelper do
       expect(helper.board_data[:lists_endpoint]).to eq(board_lists_path(board))
     end
   end
+
+  describe '#current_board_json' do
+    let(:board_json) { helper.current_board_json }
+
+    it 'can serialise with a basic set of attributes' do
+      board = create(:board, project: project)
+      assign(:board, board)
+
+      expect(board_json).to match_schema('current-board')
+    end
+  end
 end