Merge branch 'winh-issue-boards-setListDetail' into 'master'

Extract setListDetail() into issue boards store

See merge request gitlab-org/gitlab-ce!29063

app/assets/javascripts/boards/components/board_card.vue

@@ -66,7 +66,7 @@ export default {
           eventHub.$emit('clearDetailIssue');
         } else {
           eventHub.$emit('newDetailIssue', this.issue);
-          boardsStore.detail.list = this.list;
+          boardsStore.setListDetail(this.list);
         }
       }
     },

app/assets/javascripts/boards/components/board_new_issue.vue

@@ -73,7 +73,7 @@ export default {
           $(this.$refs.submitButton).enable();
 
           boardsStore.setIssueDetail(issue);
-          boardsStore.detail.list = this.list;
+          boardsStore.setListDetail(this.list);
         })
         .catch(() => {
           // Need this because our jQuery very kindly disables buttons on ALL form submissions

app/assets/javascripts/boards/stores/boards_store.js

@@ -207,6 +207,10 @@ const boardsStore = {
     eventHub.$emit('updateTokens');
   },
 
+  setListDetail(newList) {
+    this.detail.list = newList;
+  },
+
   updateFiltersUrl() {
     window.history.pushState(null, null, `?${this.filter.path}`);
   },

spec/javascripts/boards/boards_store_spec.js

@@ -312,6 +312,17 @@ describe('Store', () => {
     });
   });
 
+  describe('setListDetail', () => {
+    it('sets the list detail', () => {
+      boardsStore.detail.list = 'not a list';
+
+      const dummyValue = 'new list';
+      boardsStore.setListDetail(dummyValue);
+
+      expect(boardsStore.detail.list).toEqual(dummyValue);
+    });
+  });
+
   describe('clearDetailIssue', () => {
     it('resets issue details', () => {
       boardsStore.detail.issue = 'something';