Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
801fc90c
Commit
801fc90c
authored
Nov 19, 2018
by
Heinrich Lee Yu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor to use updated params in finder
parent
263849f6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
15 deletions
+4
-15
app/helpers/application_helper.rb
app/helpers/application_helper.rb
+0
-15
app/helpers/issuables_helper.rb
app/helpers/issuables_helper.rb
+4
-0
No files found.
app/helpers/application_helper.rb
View file @
801fc90c
...
@@ -188,21 +188,6 @@ module ApplicationHelper
...
@@ -188,21 +188,6 @@ module ApplicationHelper
"
#{
request
.
path
}
?
#{
params
.
to_param
}
"
"
#{
request
.
path
}
?
#{
params
.
to_param
}
"
end
end
def
filter_bar_params
{
milestone_title:
params
[
:milestone_title
],
assignee_id:
params
[
:assignee_id
],
author_id:
params
[
:author_id
],
search:
params
[
:search
],
label_name:
params
[
:label_name
],
my_reaction_emoji:
params
[
:my_reaction_emoji
]
}
end
def
has_filter_bar_param?
filter_bar_params
.
values
.
any?
{
|
v
|
v
.
present?
}
end
def
outdated_browser?
def
outdated_browser?
browser
.
ie?
&&
browser
.
version
.
to_i
<
10
browser
.
ie?
&&
browser
.
version
.
to_i
<
10
end
end
...
...
app/helpers/issuables_helper.rb
View file @
801fc90c
...
@@ -362,6 +362,10 @@ module IssuablesHelper
...
@@ -362,6 +362,10 @@ module IssuablesHelper
end
end
end
end
def
has_filter_bar_param?
finder
.
class
.
scalar_params
.
any?
{
|
p
|
params
[
p
].
present?
}
end
private
private
def
sidebar_gutter_collapsed?
def
sidebar_gutter_collapsed?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment