Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
89ec120f
Commit
89ec120f
authored
May 09, 2018
by
Dylan Griffith
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add validation Ci::Runner runner_type must be present
parent
4c2cf907
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
0 deletions
+2
-0
app/models/ci/runner.rb
app/models/ci/runner.rb
+1
-0
spec/models/ci/runner_spec.rb
spec/models/ci/runner_spec.rb
+1
-0
No files found.
app/models/ci/runner.rb
View file @
89ec120f
...
@@ -58,6 +58,7 @@ module Ci
...
@@ -58,6 +58,7 @@ module Ci
validate
:tag_constraints
validate
:tag_constraints
validate
:either_projects_or_group
validate
:either_projects_or_group
validates
:access_level
,
presence:
true
validates
:access_level
,
presence:
true
validates
:runner_type
,
presence:
true
acts_as_taggable
acts_as_taggable
...
...
spec/models/ci/runner_spec.rb
View file @
89ec120f
...
@@ -3,6 +3,7 @@ require 'spec_helper'
...
@@ -3,6 +3,7 @@ require 'spec_helper'
describe
Ci
::
Runner
do
describe
Ci
::
Runner
do
describe
'validation'
do
describe
'validation'
do
it
{
is_expected
.
to
validate_presence_of
(
:access_level
)
}
it
{
is_expected
.
to
validate_presence_of
(
:access_level
)
}
it
{
is_expected
.
to
validate_presence_of
(
:runner_type
)
}
context
'when runner is not allowed to pick untagged jobs'
do
context
'when runner is not allowed to pick untagged jobs'
do
context
'when runner does not have tags'
do
context
'when runner does not have tags'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment