Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8ba48310
Commit
8ba48310
authored
Jul 17, 2019
by
Ammar Alakkad
Committed by
Kushal Pandya
Jul 17, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Label picker: Line break on long label titles"
parent
c11eb0c3
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
2 deletions
+12
-2
app/assets/javascripts/labels_select.js
app/assets/javascripts/labels_select.js
+2
-1
app/assets/stylesheets/pages/labels.scss
app/assets/stylesheets/pages/labels.scss
+4
-0
changelogs/unreleased/48771-label-picker-line-break-on-long-label-titles.yml
...ed/48771-label-picker-line-break-on-long-label-titles.yml
+5
-0
spec/features/issues/bulk_assignment_labels_spec.rb
spec/features/issues/bulk_assignment_labels_spec.rb
+1
-1
No files found.
app/assets/javascripts/labels_select.js
View file @
8ba48310
...
...
@@ -311,7 +311,8 @@ export default class LabelsSelect {
// We need to identify which items are actually labels
if
(
label
.
id
)
{
selectedClass
.
push
(
'
label-item
'
);
const
selectedLayoutClasses
=
[
'
d-flex
'
,
'
flex-row
'
,
'
text-break-word
'
];
selectedClass
.
push
(
'
label-item
'
,
...
selectedLayoutClasses
);
linkEl
.
dataset
.
labelId
=
label
.
id
;
}
...
...
app/assets/stylesheets/pages/labels.scss
View file @
8ba48310
...
...
@@ -30,6 +30,10 @@
.dropdown-content
{
max-height
:
135px
;
}
.dropdown-label-box
{
flex
:
0
0
auto
;
}
}
.dropdown-new-label
{
...
...
changelogs/unreleased/48771-label-picker-line-break-on-long-label-titles.yml
0 → 100644
View file @
8ba48310
---
title
:
'
Resolve
Label
picker:
Line
break
on
long
label
titles'
merge_request
:
30610
author
:
type
:
fixed
spec/features/issues/bulk_assignment_labels_spec.rb
View file @
8ba48310
...
...
@@ -381,7 +381,7 @@ describe 'Issues > Labels bulk assignment' do
if
unmark
items
.
map
do
|
item
|
# Make sure we are unmarking the item no matter the state it has currently
click_link
item
until
find
(
'a'
,
text:
item
)[
:class
]
==
'label-item'
click_link
item
until
find
(
'a'
,
text:
item
)[
:class
]
.
include?
'label-item'
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment