Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
9753a7d2
Commit
9753a7d2
authored
Jun 26, 2019
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Set higher TTL to write lock for traces
Set higher TTL is safer option when it comes to long running archive
parent
b52e3b2d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
changelogs/unreleased/set-higher-ttl-for-trace-write.yml
changelogs/unreleased/set-higher-ttl-for-trace-write.yml
+5
-0
lib/gitlab/ci/trace.rb
lib/gitlab/ci/trace.rb
+1
-1
spec/support/shared_examples/ci_trace_shared_examples.rb
spec/support/shared_examples/ci_trace_shared_examples.rb
+1
-1
No files found.
changelogs/unreleased/set-higher-ttl-for-trace-write.yml
0 → 100644
View file @
9753a7d2
---
title
:
Set higher TTL for write lock of trace to prevent concurrent archiving
merge_request
:
30064
author
:
type
:
fixed
lib/gitlab/ci/trace.rb
View file @
9753a7d2
...
...
@@ -5,7 +5,7 @@ module Gitlab
class
Trace
include
::
Gitlab
::
ExclusiveLeaseHelpers
LOCK_TTL
=
1
.
minute
LOCK_TTL
=
1
0
.
minutes
LOCK_RETRIES
=
2
LOCK_SLEEP
=
0.001
.
seconds
...
...
spec/support/shared_examples/ci_trace_shared_examples.rb
View file @
9753a7d2
...
...
@@ -270,7 +270,7 @@ shared_examples_for 'common trace features' do
include
ExclusiveLeaseHelpers
before
do
stub_exclusive_lease_taken
(
"trace:write:lock:
#{
trace
.
job
.
id
}
"
,
timeout:
1
.
minute
)
stub_exclusive_lease_taken
(
"trace:write:lock:
#{
trace
.
job
.
id
}
"
,
timeout:
1
0
.
minutes
)
end
it
'blocks concurrent archiving'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment