Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
9870e86f
Commit
9870e86f
authored
Jul 29, 2019
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use the --atomic flag when deploying Review Apps
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
14e7cbe5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
7 deletions
+1
-7
scripts/review_apps/review-apps.sh
scripts/review_apps/review-apps.sh
+1
-7
No files found.
scripts/review_apps/review-apps.sh
View file @
9870e86f
...
...
@@ -189,17 +189,11 @@ function deploy() {
gitlab_shell_image_repository
=
"
${
IMAGE_REPOSITORY
}
/gitlab-shell"
gitlab_workhorse_image_repository
=
"
${
IMAGE_REPOSITORY
}
/gitlab-workhorse-
${
IMAGE_VERSION
}
"
# Cleanup and previous installs, as FAILED and PENDING_UPGRADE will cause errors with `upgrade`
if
[
"
$CI_ENVIRONMENT_SLUG
"
!=
"production"
]
&&
previous_deploy_failed
"
$CI_ENVIRONMENT_SLUG
"
;
then
echo
"Deployment in bad state, cleaning up
$CI_ENVIRONMENT_SLUG
"
delete
fi
create_application_secret
HELM_CMD
=
$(
cat
<<
EOF
helm upgrade --install
\
--
wait
\
--
atomic
\
--timeout 900
\
--set releaseOverride="
$CI_ENVIRONMENT_SLUG
"
\
--set global.appConfig.enableUsagePing=false
\
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment