Commit 9b807a10 authored by Shinya Maeda's avatar Shinya Maeda

Improve test quality

parent 66d43c84
...@@ -25,7 +25,7 @@ describe 'Environment' do ...@@ -25,7 +25,7 @@ describe 'Environment' do
end end
context 'without deployments' do context 'without deployments' do
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end
...@@ -64,7 +64,7 @@ describe 'Environment' do ...@@ -64,7 +64,7 @@ describe 'Environment' do
create(:deployment, :running, environment: environment, deployable: build) create(:deployment, :running, environment: environment, deployable: build)
end end
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end
...@@ -77,7 +77,7 @@ describe 'Environment' do ...@@ -77,7 +77,7 @@ describe 'Environment' do
create(:deployment, :failed, environment: environment, deployable: build) create(:deployment, :failed, environment: environment, deployable: build)
end end
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end
......
...@@ -99,7 +99,7 @@ describe EnvironmentStatus do ...@@ -99,7 +99,7 @@ describe EnvironmentStatus do
let(:user) { project.owner } let(:user) { project.owner }
before do before do
build.deployment&.update(sha: sha) build.deployment&.update!(sha: sha)
end end
context 'when environment is created on a forked project' do context 'when environment is created on a forked project' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment