Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
9b807a10
Commit
9b807a10
authored
Nov 07, 2018
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve test quality
parent
66d43c84
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
spec/features/projects/environments/environment_spec.rb
spec/features/projects/environments/environment_spec.rb
+3
-3
spec/models/environment_status_spec.rb
spec/models/environment_status_spec.rb
+1
-1
No files found.
spec/features/projects/environments/environment_spec.rb
View file @
9b807a10
...
@@ -25,7 +25,7 @@ describe 'Environment' do
...
@@ -25,7 +25,7 @@ describe 'Environment' do
end
end
context
'without deployments'
do
context
'without deployments'
do
it
'does
show no
deployments'
do
it
'does
not show
deployments'
do
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
end
end
end
end
...
@@ -64,7 +64,7 @@ describe 'Environment' do
...
@@ -64,7 +64,7 @@ describe 'Environment' do
create
(
:deployment
,
:running
,
environment:
environment
,
deployable:
build
)
create
(
:deployment
,
:running
,
environment:
environment
,
deployable:
build
)
end
end
it
'does
show no
deployments'
do
it
'does
not show
deployments'
do
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
end
end
end
end
...
@@ -77,7 +77,7 @@ describe 'Environment' do
...
@@ -77,7 +77,7 @@ describe 'Environment' do
create
(
:deployment
,
:failed
,
environment:
environment
,
deployable:
build
)
create
(
:deployment
,
:failed
,
environment:
environment
,
deployable:
build
)
end
end
it
'does
show no
deployments'
do
it
'does
not show
deployments'
do
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
expect
(
page
).
to
have_content
(
'You don\'t have any deployments right now.'
)
end
end
end
end
...
...
spec/models/environment_status_spec.rb
View file @
9b807a10
...
@@ -99,7 +99,7 @@ describe EnvironmentStatus do
...
@@ -99,7 +99,7 @@ describe EnvironmentStatus do
let
(
:user
)
{
project
.
owner
}
let
(
:user
)
{
project
.
owner
}
before
do
before
do
build
.
deployment
&
.
update
(
sha:
sha
)
build
.
deployment
&
.
update
!
(
sha:
sha
)
end
end
context
'when environment is created on a forked project'
do
context
'when environment is created on a forked project'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment