Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
9e5bc599
Commit
9e5bc599
authored
Aug 02, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed Web IDE row dropdowns scrolling list incorrectly
Closes #49892
parent
d4eeee2a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
app/assets/javascripts/ide/components/new_dropdown/index.vue
app/assets/javascripts/ide/components/new_dropdown/index.vue
+3
-1
spec/javascripts/ide/components/new_dropdown/index_spec.js
spec/javascripts/ide/components/new_dropdown/index_spec.js
+3
-1
No files found.
app/assets/javascripts/ide/components/new_dropdown/index.vue
View file @
9e5bc599
...
@@ -35,7 +35,9 @@ export default {
...
@@ -35,7 +35,9 @@ export default {
watch
:
{
watch
:
{
dropdownOpen
()
{
dropdownOpen
()
{
this
.
$nextTick
(()
=>
{
this
.
$nextTick
(()
=>
{
this
.
$refs
.
dropdownMenu
.
scrollIntoView
();
this
.
$refs
.
dropdownMenu
.
scrollIntoView
({
block
:
'
nearest
'
,
});
});
});
},
},
mouseOver
()
{
mouseOver
()
{
...
...
spec/javascripts/ide/components/new_dropdown/index_spec.js
View file @
9e5bc599
...
@@ -62,7 +62,9 @@ describe('new dropdown component', () => {
...
@@ -62,7 +62,9 @@ describe('new dropdown component', () => {
vm
.
dropdownOpen
=
true
;
vm
.
dropdownOpen
=
true
;
setTimeout
(()
=>
{
setTimeout
(()
=>
{
expect
(
vm
.
$refs
.
dropdownMenu
.
scrollIntoView
).
toHaveBeenCalled
();
expect
(
vm
.
$refs
.
dropdownMenu
.
scrollIntoView
).
toHaveBeenCalledWith
({
block
:
'
nearest
'
,
});
done
();
done
();
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment