Commit a33aacd5 authored by Luke "Jared" Bennett's avatar Luke "Jared" Bennett

Further fixes for feature spec

parent 1065ba40
...@@ -12,6 +12,34 @@ shared_examples 'discussion comments' do |resource_name| ...@@ -12,6 +12,34 @@ shared_examples 'discussion comments' do |resource_name|
expect(page).to have_selector toggle_selector expect(page).to have_selector toggle_selector
end end
it '"Comment" will post a comment' do
find("#{form_selector} .note-textarea").send_keys('a')
find(submit_selector).click
find('.timeline .timeline-entry', match: :first)
new_comment = all('.timeline .timeline-entry').last
expect(new_comment).to have_content 'a'
expect(new_comment).not_to have_selector '.discussion'
end
if resource_name =~ /(issue|merge request)/
it "'Comment & close #{resource_name}' will post a comment and close the #{resource_name}" do
find("#{form_selector} .note-textarea").send_keys('a')
find(close_selector).click
find('.timeline .timeline-entry', match: :first)
entries = all('.timeline .timeline-entry')
close_note = entries.last
new_comment = entries[-2]
expect(close_note).to have_content 'closed'
expect(new_comment).not_to have_selector '.discussion'
end
end
describe 'when the toggle is clicked' do describe 'when the toggle is clicked' do
before do before do
find("#{form_selector} .note-textarea").send_keys('a') find("#{form_selector} .note-textarea").send_keys('a')
...@@ -50,30 +78,6 @@ shared_examples 'discussion comments' do |resource_name| ...@@ -50,30 +78,6 @@ shared_examples 'discussion comments' do |resource_name|
expect(items.last['class']).not_to match 'droplab-item-selected' expect(items.last['class']).not_to match 'droplab-item-selected'
end end
it '"Comment" will post a comment' do
find(submit_selector).click
find('.timeline .timeline-entry', match: :first)
new_comment = all('.timeline .timeline-entry').last
expect(new_comment).to have_content 'a'
expect(new_comment).not_to have_selector '.discussion'
end
if resource_name =~ /(issue|merge request)/
it "Comment & close' will post a comment and close the #{resource_name}" do
find(close_selector).click
find('.timeline .timeline-entry', match: :first)
entries = all('.timeline .timeline-entry')
close_note = entries.last
new_comment = entries[-2]
expect(close_note).to have_content 'closed'
expect(new_comment).not_to have_selector '.discussion'
end
end
it 'closes the menu when clicking the toggle' do it 'closes the menu when clicking the toggle' do
find(toggle_selector).click find(toggle_selector).click
...@@ -121,7 +125,7 @@ shared_examples 'discussion comments' do |resource_name| ...@@ -121,7 +125,7 @@ shared_examples 'discussion comments' do |resource_name|
end end
if resource_name =~ /(issue|merge request)/ if resource_name =~ /(issue|merge request)/
it "'Start discussion & close' will post a discussion and close the #{resource_name}" do it "'Start discussion & close #{resource_name}' will post a discussion and close the #{resource_name}" do
find(close_selector).click find(close_selector).click
find('.timeline .timeline-entry', match: :first) find('.timeline .timeline-entry', match: :first)
...@@ -204,6 +208,7 @@ end ...@@ -204,6 +208,7 @@ end
describe 'Discussion Comments', :feature, :js do describe 'Discussion Comments', :feature, :js do
include RepoHelpers include RepoHelpers
include WaitForAjax
let(:user) { create(:user) } let(:user) { create(:user) }
let(:project) { create(:project) } let(:project) { create(:project) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment