Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
a5d2ce8e
Commit
a5d2ce8e
authored
Jul 26, 2017
by
Casper
Committed by
Rémy Coutable
Jul 26, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use LDAP-attributes configured in gitlab.yml in lookup instead of just hard-coded attributes.
parent
0c563225
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
lib/gitlab/ldap/adapter.rb
lib/gitlab/ldap/adapter.rb
+1
-1
spec/lib/gitlab/ldap/adapter_spec.rb
spec/lib/gitlab/ldap/adapter_spec.rb
+3
-3
No files found.
lib/gitlab/ldap/adapter.rb
View file @
a5d2ce8e
...
@@ -101,7 +101,7 @@ module Gitlab
...
@@ -101,7 +101,7 @@ module Gitlab
end
end
def
user_attributes
def
user_attributes
%W(
#{
config
.
uid
}
cn
mail dn)
%W(
#{
config
.
uid
}
cn
dn)
+
config
.
attributes
[
'username'
]
+
config
.
attributes
[
'email'
]
end
end
end
end
end
end
...
...
spec/lib/gitlab/ldap/adapter_spec.rb
View file @
a5d2ce8e
...
@@ -16,7 +16,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
...
@@ -16,7 +16,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
expect
(
adapter
).
to
receive
(
:ldap_search
)
do
|
arg
|
expect
(
adapter
).
to
receive
(
:ldap_search
)
do
|
arg
|
expect
(
arg
[
:filter
].
to_s
).
to
eq
(
'(uid=johndoe)'
)
expect
(
arg
[
:filter
].
to_s
).
to
eq
(
'(uid=johndoe)'
)
expect
(
arg
[
:base
]).
to
eq
(
'dc=example,dc=com'
)
expect
(
arg
[
:base
]).
to
eq
(
'dc=example,dc=com'
)
expect
(
arg
[
:attributes
]).
to
match
(
%w{uid cn
mail dn
}
)
expect
(
arg
[
:attributes
]).
to
match
(
%w{uid cn
dn uid userid sAMAccountName mail email userPrincipalName
}
)
end
.
and_return
({})
end
.
and_return
({})
adapter
.
users
(
'uid'
,
'johndoe'
)
adapter
.
users
(
'uid'
,
'johndoe'
)
...
@@ -26,7 +26,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
...
@@ -26,7 +26,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
expect
(
adapter
).
to
receive
(
:ldap_search
).
with
(
expect
(
adapter
).
to
receive
(
:ldap_search
).
with
(
base:
'uid=johndoe,ou=users,dc=example,dc=com'
,
base:
'uid=johndoe,ou=users,dc=example,dc=com'
,
scope:
Net
::
LDAP
::
SearchScope_BaseObject
,
scope:
Net
::
LDAP
::
SearchScope_BaseObject
,
attributes:
%w{uid cn
mail dn
}
,
attributes:
%w{uid cn
dn uid userid sAMAccountName mail email userPrincipalName
}
,
filter:
nil
filter:
nil
).
and_return
({})
).
and_return
({})
...
@@ -63,7 +63,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
...
@@ -63,7 +63,7 @@ describe Gitlab::LDAP::Adapter, lib: true do
it
'uses the right uid attribute when non-default'
do
it
'uses the right uid attribute when non-default'
do
stub_ldap_config
(
uid:
'sAMAccountName'
)
stub_ldap_config
(
uid:
'sAMAccountName'
)
expect
(
adapter
).
to
receive
(
:ldap_search
).
with
(
expect
(
adapter
).
to
receive
(
:ldap_search
).
with
(
hash_including
(
attributes:
%w{sAMAccountName cn
mail dn
}
)
hash_including
(
attributes:
%w{sAMAccountName cn
dn uid userid sAMAccountName mail email userPrincipalName
}
)
).
and_return
({})
).
and_return
({})
adapter
.
users
(
'sAMAccountName'
,
'johndoe'
)
adapter
.
users
(
'sAMAccountName'
,
'johndoe'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment