Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
afae4cb2
Commit
afae4cb2
authored
Aug 10, 2017
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Render new issue link in failed job as a regular link instead of a UJS one
parent
188181b7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
3 deletions
+7
-3
app/assets/javascripts/jobs/components/header.vue
app/assets/javascripts/jobs/components/header.vue
+1
-1
app/assets/javascripts/vue_shared/components/header_ci_component.vue
...javascripts/vue_shared/components/header_ci_component.vue
+2
-2
changelogs/unreleased/36158-new-issue-button.yml
changelogs/unreleased/36158-new-issue-button.yml
+4
-0
No files found.
app/assets/javascripts/jobs/components/header.vue
View file @
afae4cb2
...
@@ -40,7 +40,7 @@
...
@@ -40,7 +40,7 @@
label
:
'
New issue
'
,
label
:
'
New issue
'
,
path
:
this
.
job
.
new_issue_path
,
path
:
this
.
job
.
new_issue_path
,
cssClass
:
'
js-new-issue btn btn-new btn-inverted visible-md-block visible-lg-block
'
,
cssClass
:
'
js-new-issue btn btn-new btn-inverted visible-md-block visible-lg-block
'
,
type
:
'
ujs-
link
'
,
type
:
'
link
'
,
});
});
}
}
...
...
app/assets/javascripts/vue_shared/components/header_ci_component.vue
View file @
afae4cb2
...
@@ -120,7 +120,7 @@ export default {
...
@@ -120,7 +120,7 @@ export default {
</a>
</a>
<a
<a
v-if=
"action.type === 'ujs-link'"
v-
else-
if=
"action.type === 'ujs-link'"
:href=
"action.path"
:href=
"action.path"
data-method=
"post"
data-method=
"post"
rel=
"nofollow"
rel=
"nofollow"
...
@@ -129,7 +129,7 @@ export default {
...
@@ -129,7 +129,7 @@ export default {
</a>
</a>
<button
<button
v-else=
"action.type === 'button'"
v-else
-if
=
"action.type === 'button'"
@
click=
"onClickAction(action)"
@
click=
"onClickAction(action)"
:disabled=
"action.isLoading"
:disabled=
"action.isLoading"
:class=
"action.cssClass"
:class=
"action.cssClass"
...
...
changelogs/unreleased/36158-new-issue-button.yml
0 → 100644
View file @
afae4cb2
---
title
:
Fixes new issue button for failed job returning
404
merge_request
:
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment