Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
afcfe182
Commit
afcfe182
authored
Nov 18, 2017
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check behaviour when adding more than one cluster
parent
1a9cef79
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
56 additions
and
30 deletions
+56
-30
spec/services/clusters/create_service_spec.rb
spec/services/clusters/create_service_spec.rb
+56
-30
No files found.
spec/services/clusters/create_service_spec.rb
View file @
afcfe182
...
...
@@ -7,46 +7,69 @@ describe Clusters::CreateService do
let
(
:result
)
{
described_class
.
new
(
project
,
user
,
params
).
execute
(
access_token
)
}
context
'when provider is gcp'
do
context
'when correct params'
do
let
(
:params
)
do
{
name:
'test-cluster'
,
provider_type: :gcp
,
provider_gcp_attributes:
{
gcp_project_id:
'gcp-project'
,
zone:
'us-central1-a'
,
num_nodes:
1
,
machine_type:
'machine_type-a'
context
'when project has no clusters'
do
context
'when correct params'
do
let
(
:params
)
do
{
name:
'test-cluster'
,
provider_type: :gcp
,
provider_gcp_attributes:
{
gcp_project_id:
'gcp-project'
,
zone:
'us-central1-a'
,
num_nodes:
1
,
machine_type:
'machine_type-a'
}
}
}
end
end
it
'creates a cluster object and performs a worker'
do
expect
(
ClusterProvisionWorker
).
to
receive
(
:perform_async
)
it
'creates a cluster object and performs a worker'
do
expect
(
ClusterProvisionWorker
).
to
receive
(
:perform_async
)
expect
{
result
}
.
to
change
{
Clusters
::
Cluster
.
count
}.
by
(
1
)
.
and
change
{
Clusters
::
Providers
::
Gcp
.
count
}.
by
(
1
)
expect
{
result
}
.
to
change
{
Clusters
::
Cluster
.
count
}.
by
(
1
)
.
and
change
{
Clusters
::
Providers
::
Gcp
.
count
}.
by
(
1
)
expect
(
result
.
name
).
to
eq
(
'test-cluster'
)
expect
(
result
.
user
).
to
eq
(
user
)
expect
(
result
.
project
).
to
eq
(
project
)
expect
(
result
.
provider
.
gcp_project_id
).
to
eq
(
'gcp-project'
)
expect
(
result
.
provider
.
zone
).
to
eq
(
'us-central1-a'
)
expect
(
result
.
provider
.
num_nodes
).
to
eq
(
1
)
expect
(
result
.
provider
.
machine_type
).
to
eq
(
'machine_type-a'
)
expect
(
result
.
provider
.
access_token
).
to
eq
(
access_token
)
expect
(
result
.
platform
).
to
be_nil
expect
(
result
.
name
).
to
eq
(
'test-cluster'
)
expect
(
result
.
user
).
to
eq
(
user
)
expect
(
result
.
project
).
to
eq
(
project
)
expect
(
result
.
provider
.
gcp_project_id
).
to
eq
(
'gcp-project'
)
expect
(
result
.
provider
.
zone
).
to
eq
(
'us-central1-a'
)
expect
(
result
.
provider
.
num_nodes
).
to
eq
(
1
)
expect
(
result
.
provider
.
machine_type
).
to
eq
(
'machine_type-a'
)
expect
(
result
.
provider
.
access_token
).
to
eq
(
access_token
)
expect
(
result
.
platform
).
to
be_nil
end
end
context
'when invalid params'
do
let
(
:params
)
do
{
name:
'test-cluster'
,
provider_type: :gcp
,
provider_gcp_attributes:
{
gcp_project_id:
'!!!!!!!'
,
zone:
'us-central1-a'
,
num_nodes:
1
,
machine_type:
'machine_type-a'
}
}
end
it
'returns an error'
do
expect
(
ClusterProvisionWorker
).
not_to
receive
(
:perform_async
)
expect
{
result
}.
to
change
{
Clusters
::
Cluster
.
count
}.
by
(
0
)
expect
(
result
.
errors
[
:"provider_gcp.gcp_project_id"
]).
to
be_present
end
end
end
context
'when
invalid params
'
do
context
'when
project has a cluster
'
do
let
(
:params
)
do
{
name:
'test-cluster'
,
provider_type: :gcp
,
provider_gcp_attributes:
{
gcp_project_id:
'
!!!!!!!
'
,
gcp_project_id:
'
gcp-project
'
,
zone:
'us-central1-a'
,
num_nodes:
1
,
machine_type:
'machine_type-a'
...
...
@@ -54,10 +77,13 @@ describe Clusters::CreateService do
}
end
it
'returns an error'
do
before
do
Clusters
::
Cluster
.
create
(
params
.
merge
(
user:
user
,
projects:
[
project
]))
end
it
'does not create a cluster'
do
expect
(
ClusterProvisionWorker
).
not_to
receive
(
:perform_async
)
expect
{
result
}.
to
change
{
Clusters
::
Cluster
.
count
}.
by
(
0
)
expect
(
result
.
errors
[
:"provider_gcp.gcp_project_id"
]).
to
be_present
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment