Assert on no Gitaly requests in a job show tests

b0360335 · Grzegorz Bizon · Filipa Lacerda · d457f3d3 · b0360335
Commit b0360335 authored May 06, 2019 by Grzegorz Bizon Committed by Filipa Lacerda May 24, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

spec/controllers/projects/jobs_controller_spec.rb spec/controllers/projects/jobs_controller_spec.rb +2 -4

No files found.
--- a/spec/controllers/projects/jobs_controller_spec.rb
+++ b/spec/controllers/projects/jobs_controller_spec.rb
@@ -496,10 +496,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
    end

    def get_show_json
-      get_show(id: job.id, format: :json)
-
-      puts 'X'*50
-      puts Gitlab::GitalyClient.get_request_count
+      expect { get_show(id: job.id, format: :json) }
+        .not_to change { Gitlab::GitalyClient.get_request_count }
    end

    def get_show(**extra_params)