Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
b4c2dd73
Commit
b4c2dd73
authored
Feb 08, 2019
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Wait for viewers to load
Adds qa-spinner class and wait for it to go away before making assertions.
parent
724e904c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
2 deletions
+16
-2
app/views/projects/blob/viewers/_loading.html.haml
app/views/projects/blob/viewers/_loading.html.haml
+1
-1
qa/qa/page/project/show.rb
qa/qa/page/project/show.rb
+10
-0
qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb
...er_ui/3_create/repository/push_http_private_token_spec.rb
+5
-1
No files found.
app/views/projects/blob/viewers/_loading.html.haml
View file @
b4c2dd73
.text-center.prepend-top-default.append-bottom-default
=
icon
(
'spinner spin 2x'
,
'aria-hidden'
=>
'true'
,
'aria-label'
=>
'Loading content…'
)
=
icon
(
'spinner spin 2x'
,
'aria-hidden'
=>
'true'
,
'aria-label'
=>
'Loading content…'
,
class:
'qa-spinner'
)
qa/qa/page/project/show.rb
View file @
b4c2dd73
...
...
@@ -51,6 +51,16 @@ module QA
element
:branches_dropdown
end
view
'app/views/projects/blob/viewers/_loading.html.haml'
do
element
:spinner
end
def
wait_for_viewers_to_load
wait
(
reload:
false
)
do
has_no_element?
(
:spinner
)
end
end
def
create_first_new_file!
within_element
(
:quick_actions
)
do
click_link_with_text
'New file'
...
...
qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb
View file @
b4c2dd73
...
...
@@ -22,7 +22,11 @@ module QA
end
push
.
project
.
visit!
Page
::
Project
::
Show
.
perform
(
&
:wait_for_push
)
Page
::
Project
::
Show
.
perform
do
|
page
|
page
.
wait_for_push
page
.
wait_for_viewers_to_load
end
expect
(
page
).
to
have_content
(
'README.md'
)
expect
(
page
).
to
have_content
(
'This is a test project'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment