Commit bdb64ac0 authored by Grzegorz Bizon's avatar Grzegorz Bizon

Merge branch '36907-fix-new-issue-link-from-failed-job' into 'master'

Resolve "New issue from failed build no longer links to failed build"

Closes #36907

See merge request gitlab-org/gitlab-ce!20328
parents d285356e 2b78f223
...@@ -35,7 +35,7 @@ class BuildDetailsEntity < JobEntity ...@@ -35,7 +35,7 @@ class BuildDetailsEntity < JobEntity
def build_failed_issue_options def build_failed_issue_options
{ title: "Job Failed ##{build.id}", { title: "Job Failed ##{build.id}",
description: "Job [##{build.id}](#{project_job_path(project, build)}) failed for #{build.sha}:\n" } description: "Job [##{build.id}](#{project_job_url(project, build)}) failed for #{build.sha}:\n" }
end end
def current_user def current_user
......
---
title: Fix link to job when creating a new issue from a failed job
merge_request: 20328
author:
type: fixed
...@@ -165,7 +165,7 @@ feature 'Jobs', :clean_gitlab_redis_shared_state do ...@@ -165,7 +165,7 @@ feature 'Jobs', :clean_gitlab_redis_shared_state do
it 'links to issues/new with the title and description filled in' do it 'links to issues/new with the title and description filled in' do
button_title = "Job Failed ##{job.id}" button_title = "Job Failed ##{job.id}"
job_url = project_job_path(project, job) job_url = project_job_url(project, job, host: page.server.host, port: page.server.port)
options = { issue: { title: button_title, description: "Job [##{job.id}](#{job_url}) failed for #{job.sha}:\n" } } options = { issue: { title: button_title, description: "Job [##{job.id}](#{job_url}) failed for #{job.sha}:\n" } }
href = new_project_issue_path(project, options) href = new_project_issue_path(project, options)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment