Merge branch 'master' into 42886-followup-to-new-design-for-cancel-stop-pipeline-confirmation

CHANGELOG.md

@@ -2,6 +2,25 @@
 documentation](doc/development/changelog.md) for instructions on adding your own
 entry.
 
+## 10.4.4 (2018-02-16)
+
+### Security (1 change)
+
+- Update nokogiri to 1.8.2. !16807
+
+### Fixed (9 changes)
+
+- Fix 500 error when loading a merge request with an invalid comment. !16795
+- Cleanup new branch/merge request form in issues. !16854
+- Fix GitLab import leaving group_id on ProjectLabel. !16877
+- Fix forking projects when no restricted visibility levels are defined applicationwide. !16881
+- Resolve PrepareUntrackedUploads PostgreSQL syntax error. !17019
+- Fixed error 500 when removing an identity with synced attributes and visiting the profile page. !17054
+- Validate user namespace before saving so that errors persist on model.
+- LDAP Person no longer throws exception on invalid entry.
+- Fix JIRA not working when a trailing slash is included.
+
+
 ## 10.4.3 (2018-02-05)
 
 ### Security (4 changes)

changelogs/unreleased/42160-error-500-loading-merge-request-undefined-method-index-for-nil-nilclass.yml

----
-title: Fix 500 error when loading a merge request with an invalid comment
-merge_request: 16795
-author:
-type: fixed

changelogs/unreleased/42591-update-nokogiri.yml

----
-title: Update nokogiri to 1.8.2
-merge_request: 16807
-author:
-type: security

changelogs/unreleased/42696-gitlab-import-leaves-group_id-on-projectlabel.yml

----
-title: Fix GitLab import leaving group_id on ProjectLabel
-merge_request: 16877
-author:
-type: fixed

changelogs/unreleased/bvl-fix-500-on-fork-without-restricted-visibility-levels.yml

----
-title: Fix forking projects when no restricted visibility levels are defined applicationwide
-merge_request: 16881
-author:
-type: fixed

changelogs/unreleased/dm-user-namespace-route-path-validation.yml

----
-title: Validate user namespace before saving so that errors persist on model
-merge_request:
-author:
-type: fixed

changelogs/unreleased/fj-37528-error-after-disabling-ldap.yml

----
-title: Fixed error 500 when removing an identity with synced attributes and visiting
-  the profile page
-merge_request: 17054
-author:
-type: fixed

changelogs/unreleased/mk-fix-no-untracked-upload-files-error.yml

----
-title: Resolve PrepareUntrackedUploads PostgreSQL syntax error
-merge_request: 17019
-author:
-type: fixed

changelogs/unreleased/remove_ldap_person_validation.yml

----
-title: LDAP Person no longer throws exception on invalid entry
-merge_request:
-author:
-type: fixed

changelogs/unreleased/sh-fix-jira-trailing-slash.yml

----
-title: Fix JIRA not working when a trailing slash is included
-merge_request:
-author:
-type: fixed

changelogs/unreleased/winh-new-branch-dropdown-style.yml

----
-title: Cleanup new branch/merge request form in issues
-merge_request: 16854
-author:
-type: fixed

lib/api/project_import.rb

@@ -41,8 +41,12 @@ module API
                       current_user.namespace
                     end
 
-        project_params = import_params.merge(namespace_id: namespace.id,
-                                             file: import_params[:file]['tempfile'])
+        project_params = {
+            path: import_params[:path],
+            namespace_id: namespace.id,
+            file: import_params[:file]['tempfile']
+        }
+
         project = ::Projects::GitlabProjectsImportService.new(current_user, project_params).execute
 
         render_api_error!(project.errors.full_messages&.first, 400) unless project.saved?

spec/requests/api/project_import_spec.rb

@@ -42,7 +42,7 @@ describe API::ProjectImport do
 
     it 'schedules an import at the user namespace level' do
       expect_any_instance_of(Project).not_to receive(:import_schedule)
-      expect(Gitlab::ImportExport::ProjectCreator).not_to receive(:new)
+      expect(::Projects::CreateService).not_to receive(:new)
 
       post api('/projects/import', user), namespace: 'nonexistent', path: 'test-import2', file: fixture_file_upload(file)
 
@@ -73,7 +73,7 @@ describe API::ProjectImport do
 
     def stub_import(namespace)
       expect_any_instance_of(Project).to receive(:import_schedule)
-      expect(Gitlab::ImportExport::ProjectCreator).to receive(:new).with(namespace.id, any_args).and_call_original
+      expect(::Projects::CreateService).to receive(:new).with(user, hash_including(namespace_id: namespace.id)).and_call_original
     end
   end