Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
d74b3cc1
Commit
d74b3cc1
authored
Jan 18, 2019
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add comments explaining the wait
parent
10763a9d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
4 deletions
+5
-4
qa/qa/page/label/index.rb
qa/qa/page/label/index.rb
+5
-4
No files found.
qa/qa/page/label/index.rb
View file @
d74b3cc1
...
...
@@ -11,10 +11,11 @@ module QA
end
def
go_to_new_label
wait
(
reload:
false
)
do
within_element
(
:label_svg
)
do
has_css?
(
'.js-lazy-loaded'
)
end
# The 'labels.svg' takes a fraction of a second to load after which the "New label" button shifts up a bit
# This can cause webdriver to miss the hit so we wait for the svg to load (implicitly with has_css?)
# before clicking the button.
within_element
(
:label_svg
)
do
has_css?
(
'.js-lazy-loaded'
)
end
click_element
:label_create_new
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment