Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
db267fa3
Commit
db267fa3
authored
Dec 11, 2018
by
Semyon Pupkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/HookArgument rubocop offense
parent
185f8a5d
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
19 deletions
+8
-19
.rubocop_todo.yml
.rubocop_todo.yml
+0
-11
spec/spec_helper.rb
spec/spec_helper.rb
+3
-3
spec/support/carrierwave.rb
spec/support/carrierwave.rb
+1
-1
spec/support/db_cleaner.rb
spec/support/db_cleaner.rb
+3
-3
spec/support/setup_builds_storage.rb
spec/support/setup_builds_storage.rb
+1
-1
No files found.
.rubocop_todo.yml
View file @
db267fa3
...
...
@@ -155,17 +155,6 @@ RSpec/ExpectChange:
RSpec/ExpectInHook
:
Enabled
:
false
# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument
:
Exclude
:
-
'
spec/spec_helper.rb'
-
'
spec/support/carrierwave.rb'
-
'
spec/support/db_cleaner.rb'
-
'
spec/support/gitaly.rb'
-
'
spec/support/setup_builds_storage.rb'
# Offense count: 19
# Configuration parameters: EnforcedStyle.
# SupportedStyles: it_behaves_like, it_should_behave_like
...
...
spec/spec_helper.rb
View file @
db267fa3
...
...
@@ -115,7 +115,7 @@ RSpec.configure do |config|
TestEnv
.
clean_test_path
end
config
.
before
(
:example
)
do
config
.
before
do
# Enable all features by default for testing
allow
(
Feature
).
to
receive
(
:enabled?
)
{
true
}
...
...
@@ -136,11 +136,11 @@ RSpec.configure do |config|
RequestStore
.
clear!
end
config
.
after
(
:example
)
do
config
.
after
do
Fog
.
unmock!
if
Fog
.
mock?
end
config
.
after
(
:example
)
do
config
.
after
do
Gitlab
::
CurrentSettings
.
clear_in_memory_application_settings!
end
...
...
spec/support/carrierwave.rb
View file @
db267fa3
CarrierWave
.
root
=
File
.
expand_path
(
'tmp/tests/public'
,
Rails
.
root
)
RSpec
.
configure
do
|
config
|
config
.
after
(
:each
)
do
config
.
after
do
FileUtils
.
rm_rf
(
CarrierWave
.
root
)
end
end
spec/support/db_cleaner.rb
View file @
db267fa3
...
...
@@ -23,7 +23,7 @@ RSpec.configure do |config|
DatabaseCleaner
.
clean_with
(
:deletion
,
cache_tables:
false
)
end
config
.
before
(
:each
)
do
config
.
before
do
DatabaseCleaner
.
strategy
=
:transaction
end
...
...
@@ -39,11 +39,11 @@ RSpec.configure do |config|
DatabaseCleaner
.
strategy
=
:deletion
,
{
cache_tables:
false
}
end
config
.
before
(
:each
)
do
config
.
before
do
DatabaseCleaner
.
start
end
config
.
append_after
(
:each
)
do
config
.
append_after
do
DatabaseCleaner
.
clean
end
end
spec/support/setup_builds_storage.rb
View file @
db267fa3
...
...
@@ -11,7 +11,7 @@ RSpec.configure do |config|
FileUtils
.
mkdir_p
(
builds_path
)
end
config
.
before
(
:each
)
do
config
.
before
do
FileUtils
.
rm_rf
(
builds_path
)
FileUtils
.
mkdir_p
(
builds_path
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment