Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
f8fdf93e
Commit
f8fdf93e
authored
Dec 07, 2018
by
George Tsiolis
Committed by
Phil Hughes
Dec 07, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Show primary button when all labels are prioritized
parent
25cd8fb5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
1 deletion
+21
-1
app/views/projects/labels/index.html.haml
app/views/projects/labels/index.html.haml
+1
-1
changelogs/unreleased/gt-show-primary-button-when-all-labels-are-prioritized.yml
...t-show-primary-button-when-all-labels-are-prioritized.yml
+5
-0
spec/features/projects/labels/update_prioritization_spec.rb
spec/features/projects/labels/update_prioritization_spec.rb
+15
-0
No files found.
app/views/projects/labels/index.html.haml
View file @
f8fdf93e
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
-
subscribed
=
params
[
:subscribed
]
-
subscribed
=
params
[
:subscribed
]
-
labels_or_filters
=
@labels
.
exists?
||
@prioritized_labels
.
exists?
||
search
.
present?
||
subscribed
.
present?
-
labels_or_filters
=
@labels
.
exists?
||
@prioritized_labels
.
exists?
||
search
.
present?
||
subscribed
.
present?
-
if
@labels
.
present?
&&
can_admin_label
-
if
labels_or_filters
&&
can_admin_label
-
content_for
(
:header_content
)
do
-
content_for
(
:header_content
)
do
.nav-controls
.nav-controls
=
link_to
_
(
'New label'
),
new_project_label_path
(
@project
),
class:
"btn btn-success qa-label-create-new"
=
link_to
_
(
'New label'
),
new_project_label_path
(
@project
),
class:
"btn btn-success qa-label-create-new"
...
...
changelogs/unreleased/gt-show-primary-button-when-all-labels-are-prioritized.yml
0 → 100644
View file @
f8fdf93e
---
title
:
Show primary button when all labels are prioritized
merge_request
:
23648
author
:
George Tsiolis
type
:
other
spec/features/projects/labels/update_prioritization_spec.rb
View file @
f8fdf93e
...
@@ -115,6 +115,21 @@ describe 'Prioritize labels' do
...
@@ -115,6 +115,21 @@ describe 'Prioritize labels' do
end
end
end
end
it
'user can see a primary button when there are only prioritized labels'
,
:js
do
visit
project_labels_path
(
project
)
page
.
within
(
'.other-labels'
)
do
all
(
'.js-toggle-priority'
).
each
do
|
el
|
el
.
click
end
wait_for_requests
end
page
.
within
(
'.breadcrumbs-container'
)
do
expect
(
page
).
to
have_link
(
'New label'
)
end
end
it
'shows a help message about prioritized labels'
do
it
'shows a help message about prioritized labels'
do
visit
project_labels_path
(
project
)
visit
project_labels_path
(
project
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment