Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
fbf638a4
Commit
fbf638a4
authored
Mar 06, 2019
by
Max Winterstein
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Unify behaviour of 'Copy commit SHA to clipboard'
parent
eb6577d0
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
2 deletions
+8
-2
app/assets/javascripts/jobs/components/commit_block.vue
app/assets/javascripts/jobs/components/commit_block.vue
+1
-1
changelogs/unreleased/MaxWinterstein-master-patch-23232.yml
changelogs/unreleased/MaxWinterstein-master-patch-23232.yml
+5
-0
spec/javascripts/jobs/components/commit_block_spec.js
spec/javascripts/jobs/components/commit_block_spec.js
+2
-1
No files found.
app/assets/javascripts/jobs/components/commit_block.vue
View file @
fbf638a4
...
@@ -39,7 +39,7 @@ export default {
...
@@ -39,7 +39,7 @@ export default {
</gl-link>
</gl-link>
<clipboard-button
<clipboard-button
:text=
"commit.
short_
id"
:text=
"commit.id"
:title=
"__('Copy commit SHA to clipboard')"
:title=
"__('Copy commit SHA to clipboard')"
css-class=
"btn btn-clipboard btn-transparent"
css-class=
"btn btn-clipboard btn-transparent"
/>
/>
...
...
changelogs/unreleased/MaxWinterstein-master-patch-23232.yml
0 → 100644
View file @
fbf638a4
---
title
:
Unify behaviour of 'Copy commit SHA to clipboard' to use full commit SHA.
merge_request
:
25829
author
:
Max Winterstein
type
:
changed
spec/javascripts/jobs/components/commit_block_spec.js
View file @
fbf638a4
...
@@ -9,6 +9,7 @@ describe('Commit block', () => {
...
@@ -9,6 +9,7 @@ describe('Commit block', () => {
const
props
=
{
const
props
=
{
commit
:
{
commit
:
{
short_id
:
'
1f0fb84f
'
,
short_id
:
'
1f0fb84f
'
,
id
:
'
1f0fb84fb6770d74d97eee58118fd3909cd4f48c
'
,
commit_path
:
'
commit/1f0fb84fb6770d74d97eee58118fd3909cd4f48c
'
,
commit_path
:
'
commit/1f0fb84fb6770d74d97eee58118fd3909cd4f48c
'
,
title
:
'
Update README.md
'
,
title
:
'
Update README.md
'
,
},
},
...
@@ -42,7 +43,7 @@ describe('Commit block', () => {
...
@@ -42,7 +43,7 @@ describe('Commit block', () => {
it
(
'
renders clipboard button
'
,
()
=>
{
it
(
'
renders clipboard button
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
button
'
).
getAttribute
(
'
data-clipboard-text
'
)).
toEqual
(
expect
(
vm
.
$el
.
querySelector
(
'
button
'
).
getAttribute
(
'
data-clipboard-text
'
)).
toEqual
(
props
.
commit
.
short_
id
,
props
.
commit
.
id
,
);
);
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment