- 26 Nov, 2019 11 commits
-
-
Justin Ho Tuan Duong authored
-
GitLab Release Tools Bot authored
Prevent guests from seeing commits for cycle analytics See merge request gitlab/gitlabhq!3534
-
GitLab Release Tools Bot authored
Related Branches Visible to Guests in Issue Activity See merge request gitlab/gitlabhq!3538
-
GitLab Release Tools Bot authored
GitLab stores AWS, Slack, Askimet, reCaptcha tokens in plaintext See merge request gitlab/gitlabhq!3543
-
GitLab Release Tools Bot authored
Use Gitlab::HTTP for all chat notifications See merge request gitlab/gitlabhq!3544
-
GitLab Release Tools Bot authored
Fix private comment Elasticsearch leak See merge request gitlab/gitlabhq!3546
-
GitLab Release Tools Bot authored
Escape namespace in label references See merge request gitlab/gitlabhq!3550
-
GitLab Release Tools Bot authored
Check permissions before showing a forked project's source See merge request gitlab/gitlabhq!3555
-
GitLab Release Tools Bot authored
Ensure attributes that end in `_ids` are cleaned See merge request gitlab/gitlabhq!3558
-
Imre Farkas authored
-
DJ Mountney authored
This prevents an issue where you can steal other projects objects by asking for ids that don't belong to you in import.
-
- 25 Nov, 2019 3 commits
-
-
Nick Thomas authored
-
Arturo Herrero authored
We had concerns about the cached values on Redis with the previous two releases strategy: First release (this commit): - Create new encrypted fields in the database. - Start populating new encrypted fields, read the encrypted fields or fallback to the plaintext fields. - Backfill the data removing the plaintext fields to the encrypted fields. Second release: - Remove the virtual attribute (created in step 2). - Drop plaintext columns from the database (empty columns after step 3). We end up with a better strategy only using migration scripts in one release: - Pre-deployment migration: Add columns required for storing encrypted values. - Pre-deployment migration: Store the encrypted values in the new columns. - Post-deployment migration: Remove the old unencrypted columns
-
Heinrich Lee Yu authored
When referencing cross-namespace labels, we append the namespace name to the rendered label. This MR escapes the name to prevent XSS attacks.
-
- 22 Nov, 2019 10 commits
-
-
GitLab Bot authored
-
Dylan Griffith authored
-
Mark Chao authored
-
Mark Chao authored
Disabled features are ignored as they are grey areas
-
Mark Chao authored
Some feature allows GUEST to access only if project is not private. This method returns access level when targeting private projects.
-
Mark Chao authored
Guest are blocked to certain feature when project is private, therefore the scope would filter additionally with REPORTER level.
-
Mark Chao authored
Remove impossible cases due to private project's features can only be private or disabled. Fix spec due to sidekiq indexing not triggered. Update guest use cases: some features has additional constraint that "Guest users are able to perform action on public/internal projects, but not private ones."
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Bot authored
-
- 21 Nov, 2019 2 commits
-
-
Hordur Freyr Yngvason authored
-
Arturo Herrero authored
This is the plan to encrypt the plaintext tokens: First release (this commit): 1. Create new encrypted fields in the database. 2. Start populating new encrypted fields, read the encrypted fields or fallback to the plaintext fields. 3. Backfill the data removing the plaintext fields to the encrypted fields. Second release: 4. Remove the virtual attribute (created in step 2). 5. Drop plaintext columns from the database (empty columns after step 3).
-
- 20 Nov, 2019 7 commits
-
-
GitLab Bot authored
-
GitLab Bot authored
-
Kerri Miller authored
Notes related to branch creation should not be shown in an issue's activity feed when the user doesn't have access to :download_code.
-
GitLab Bot authored
-
GitLab Bot authored
-
Brandon Labuschagne authored
Default number of items is 3. If this is not the case, then increase the column width of the summary items to cater for 2 items plus the date filter.
-
Aakriti Gupta authored
- if the user has access level lower than REPORTER, don't include commit count in summary
-
- 19 Nov, 2019 3 commits
-
-
GitLab Bot authored
-
GitLab Release Tools Bot authored
-
GitLab Bot authored
-
- 18 Nov, 2019 2 commits
-
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
[ci skip]
-
- 15 Nov, 2019 1 commit
-
-
GitLab Bot authored
-
- 04 Nov, 2019 1 commit
-
-
GitLab Release Tools Bot authored
-