An error occurred fetching the project authors.
  1. 13 Dec, 2017 1 commit
  2. 12 Dec, 2017 1 commit
  3. 28 Nov, 2017 1 commit
  4. 07 Nov, 2017 1 commit
    • Yorick Peterse's avatar
      Rewrite the GitHub importer from scratch · 4dfe26cd
      Yorick Peterse authored
      Prior to this MR there were two GitHub related importers:
      
      * Github::Import: the main importer used for GitHub projects
      * Gitlab::GithubImport: importer that's somewhat confusingly used for
        importing Gitea projects (apparently they have a compatible API)
      
      This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
      introduces a new GitHub importer in the Gitlab::GithubImport namespace.
      This new GitHub importer uses Sidekiq for importing multiple resources
      in parallel, though it also has the ability to import data sequentially
      should this be necessary.
      
      The new code is spread across the following directories:
      
      * lib/gitlab/github_import: this directory contains most of the importer
        code such as the classes used for importing resources.
      * app/workers/gitlab/github_import: this directory contains the Sidekiq
        workers, most of which simply use the code from the directory above.
      * app/workers/concerns/gitlab/github_import: this directory provides a
        few modules that are included in every GitHub importer worker.
      
      == Stages
      
      The import work is divided into separate stages, with each stage
      importing a specific set of data. Stages will schedule the work that
      needs to be performed, followed by scheduling a job for the
      "AdvanceStageWorker" worker. This worker will periodically check if all
      work is completed and schedule the next stage if this is the case. If
      work is not yet completed this worker will reschedule itself.
      
      Using this approach we don't have to block threads by calling `sleep()`,
      as doing so for large projects could block the thread from doing any
      work for many hours.
      
      == Retrying Work
      
      Workers will reschedule themselves whenever necessary. For example,
      hitting the GitHub API's rate limit will result in jobs rescheduling
      themselves. These jobs are not processed until the rate limit has been
      reset.
      
      == User Lookups
      
      Part of the importing process involves looking up user details in the
      GitHub API so we can map them to GitLab users. The old importer used
      an in-memory cache, but this obviously doesn't work when the work is
      spread across different threads.
      
      The new importer uses a Redis cache and makes sure we only perform
      API/database calls if absolutely necessary.  Frequently used keys are
      refreshed, and lookup misses are also cached; removing the need for
      performing API/database calls if we know we don't have the data we're
      looking for.
      
      == Performance & Models
      
      The new importer in various places uses raw INSERT statements (as
      generated by `Gitlab::Database.bulk_insert`) instead of using Rails
      models. This allows us to bypass any validations and callbacks,
      drastically reducing the number of SQL queries and Gitaly RPC calls
      necessary to import projects.
      
      To ensure the code produces valid data the corresponding tests check if
      the produced rows are valid according to the model validation rules.
      4dfe26cd
  5. 03 Oct, 2017 2 commits
  6. 30 Sep, 2017 1 commit
  7. 28 Sep, 2017 1 commit
  8. 20 Sep, 2017 1 commit
    • Yorick Peterse's avatar
      Stop using Sidekiq for updating Key#last_used_at · b3566a01
      Yorick Peterse authored
      This makes things simpler as no scheduling is involved. Further we
      remove the need for running a SELECT + UPDATE just to get the key and
      update it, whereas we only need an UPDATE when setting last_used_at
      directly in a request.
      
      The added service class takes care of updating Key#last_used_at without
      using Sidekiq. Further it makes sure we only try to obtain a Redis lease
      if we're confident that we actually need to do so, instead of always
      obtaining it. We also make sure to _only_ update last_used_at instead of
      also updating updated_at.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
      b3566a01
  9. 21 Aug, 2017 5 commits
  10. 07 Aug, 2017 1 commit
  11. 27 Jul, 2017 2 commits
  12. 12 Jun, 2017 1 commit
  13. 25 May, 2017 1 commit
    • Alexander Randa's avatar
      Implement web hooks logging · 330789c2
      Alexander Randa authored
      * implemented logging of project and system web hooks
      * implemented UI for user area (project hooks)
      * implemented UI for admin area (system hooks)
      * implemented retry of logged webhook
      * NOT imeplemented log remover
      330789c2
  14. 10 May, 2017 1 commit
    • Toon Claes's avatar
      Use worker to destroy namespaceless projects in post-deploy · 0ad80cab
      Toon Claes authored
      Destroying projects can be very time consuming. So instead of destroying them in
      the post-deploy, just schedule them and make Sidekiq do the hard work.
      
      They are scheduled in batches of 5000 records. This way the number of database
      requests is limited while also the amount data read to memory is limited.
      0ad80cab
  15. 05 May, 2017 1 commit
  16. 04 May, 2017 1 commit
  17. 21 Apr, 2017 1 commit
  18. 14 Apr, 2017 1 commit
  19. 07 Mar, 2017 1 commit
  20. 06 Mar, 2017 1 commit
  21. 17 Feb, 2017 1 commit
  22. 31 Jan, 2017 1 commit
  23. 08 Jan, 2017 1 commit
    • Vincent Wong's avatar
      Record and show last used date of SSH Keys · b6df93a5
      Vincent Wong authored
      Addresses: Issue #13810
      
      1. Adds a last_used_at attribute to the Key table/model
      2. Update a key's last_used_at whenever it gets used
      3. Display how long ago an ssh key was last used
      b6df93a5
  24. 19 Dec, 2016 1 commit
  25. 18 Nov, 2016 1 commit
  26. 09 Nov, 2016 1 commit
    • Toon Claes's avatar
      Add button to delete all merged branches · 1afab9eb
      Toon Claes authored
      It adds a button to the branches page that the user can use to delete
      all the branches that are already merged. This can be used to clean up
      all the branches that were forgotten to delete while merging MRs.
      
      Fixes #21076.
      1afab9eb
  27. 07 Nov, 2016 1 commit
    • Yorick Peterse's avatar
      Process commits in a separate worker · 509910b8
      Yorick Peterse authored
      This moves the code used for processing commits from GitPushService to
      its own Sidekiq worker: ProcessCommitWorker.
      
      Using a Sidekiq worker allows us to process multiple commits in
      parallel. This in turn will lead to issues being closed faster and cross
      references being created faster. Furthermore by isolating this code into
      a separate class it's easier to test and maintain the code.
      
      The new worker also ensures it can efficiently check which issues can be
      closed, without having to run numerous SQL queries for every issue.
      509910b8
  28. 22 Oct, 2016 1 commit
  29. 21 Oct, 2016 1 commit
    • Yorick Peterse's avatar
      Re-organize queues to use for Sidekiq · 97731760
      Yorick Peterse authored
      Dumping too many jobs in the same queue (e.g. the "default" queue) is a
      dangerous setup. Jobs that take a long time to process can effectively
      block any other work from being performed given there are enough of
      these jobs.
      
      Furthermore it becomes harder to monitor the jobs as a single queue
      could contain jobs for different workers. In such a setup the only
      reliable way of getting counts per job is to iterate over all jobs in a
      queue, which is a rather time consuming process.
      
      By using separate queues for various workers we have better control over
      throughput, we can add weight to queues, and we can monitor queues
      better. Some workers still use the same queue whenever their work is
      related. For example, the various CI pipeline workers use the same
      "pipeline" queue.
      
      This commit includes a Rails migration that moves Sidekiq jobs from the
      old queues to the new ones. This migration also takes care of doing the
      inverse if ever needed. This does require downtime as otherwise new jobs
      could be scheduled in the old queues after this migration completes.
      
      This commit also includes an RSpec test that blacklists the use of the
      "default" queue and ensures cron workers use the "cronjob" queue.
      
      Fixes gitlab-org/gitlab-ce#23370
      97731760