Because if reload is true, then we spend a lot of time waiting for page load and yielding (to has_css? etc, which already waits for the default Capybara time) anyway. And if reload is false, there’s no reason not to check what’s on the page at all times.

There doesn’t seem to be a downside.

When the subgroup doesn’t exist, this will now return false as soon as the “Sorry” text appears, instead of waiting for the default Capybara wait time.

Also, it actually seems to wait the full 60 seconds, indicating it never finds the element.

The former “user is able to protect a branch” test no longer has a lot of value after adding the new “authorized users are allowed to push” test, and its setup is redundant, so we may as well save QA spec time by combining them.

Updates templates for 11.0

See merge request gitlab-org/gitlab-ce!19573

Use same gem versions for rails5 as for rails4 where possible

Closes #47370, #46232, #47367, and #47373

See merge request gitlab-org/gitlab-ce!19498

Update settings section titles

See merge request gitlab-org/gitlab-ce!19556

Update the dependencies license list

See merge request gitlab-org/gitlab-ce!19574

Revert rename allow collaboration column

Closes #47566

See merge request gitlab-org/gitlab-ce!19582

Merge branch '45400-automatically-created-mr-uses-wrong-target-branch-when-branching-from-tag' into 'master'

Resolve "Automatically created MR uses wrong target branch (when branching from Tag)"

Closes #45400

See merge request gitlab-org/gitlab-ce!19067

Use RestoreCustomHooks RPC in restore rake task

See merge request gitlab-org/gitlab-ce!19370

Fix NotificationRecipientService spec for EE

See merge request gitlab-org/gitlab-ce!19580

Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5876/

Closes #5974

See merge request gitlab-org/gitlab-ce!19189

Remove Gitlab::Popen dependency from lib/gitlab/git

See merge request gitlab-org/gitlab-ce!19577

EE checks a license, which needs RequestStore enabled to avoid N+1
queries. However, enabling RequestStore causes Gitaly to complain about N+1
invocations, which we really don't care about here.

Automate the basic API tests in a QA scenario

Closes gitlab-qa#251

See merge request gitlab-org/gitlab-ce!19280

Allow IDE pipeline panel to be resizable

Closes #47538

See merge request gitlab-org/gitlab-ce!19558

Backport changes for Housekeeping Specs

See merge request gitlab-org/gitlab-ce!18595

fixed typos, added text for clarifiction; markdown.md

See merge request gitlab-org/gitlab-ce!19560

fixed broken links in index.md

See merge request gitlab-org/gitlab-ce!19559

Resolve "Upgrade Monaco editor and remove CopyWebpackPlugin"

Closes #44331

See merge request gitlab-org/gitlab-ce!17813

Set tooltips to have default boundary viewport

Closes #47518

See merge request gitlab-org/gitlab-ce!19561